[AOE] Fixes underutilized Premium disk recommendations in customers with Premium SSD V2 disks (#1832)

Co-authored-by: Hélder Pinto <[email protected]>

Author: helderpinto

docs-mslearn/toolkit/changelog.md

@@ -29,6 +29,11 @@ The following section lists features and enhancements that are currently in deve
 - **Added**
   - Document [how to remove private networking](hubs/private-networking.md#removing-private-networking) and switch back to public access to reduce costs ([#1342](https://github.com/microsoft/finops-toolkit/issues/1342)).
 
+### [Optimization engine](optimization-engine/overview.md)
+
+- **Fixed**
+  - Underutilized disks recommendations were not being generated when customer environment has Premium SSD V2 disks ([#1831](https://github.com/microsoft/finops-toolkit/issues/1831)).
+
 ### Bicep Registry module pending updates
 
 - Cost Management export modules for subscriptions and resource groups.

src/optimization-engine/runbooks/recommendations/Recommend-DiskOptimizationsToBlobStorage.ps1

@@ -224,7 +224,7 @@ $baseQuery = @"
     | summarize MaxIOPSMetric = max(todouble(MetricValue_s)) by ResourceId
     | join kind=inner (
         $disksTableName
-        | where TimeGenerated > ago(1d) and DiskState_s =~ 'Attached' and SKU_s startswith 'Premium'
+        | where TimeGenerated > ago(1d) and DiskState_s =~ 'Attached' and SKU_s startswith 'Premium' and SKU_s !contains "V2"
         | extend DiskTier_s = strcat(DiskTier_s, ' ', tostring(split(SKU_s, '_')[1]))
         | project ResourceId=InstanceId_s, DiskName_s, ResourceGroup = ResourceGroupName_s, SubscriptionId = SubscriptionGuid_g, Cloud_s, TenantGuid_g, Tags_s, MaxIOPSDisk=toint(DiskIOPS_s), DiskSizeGB_s, SKU_s, DiskTier_s, DiskType_s
     ) on ResourceId
@@ -237,7 +237,7 @@ $baseQuery = @"
         | summarize MaxMBsMetric = max(todouble(MetricValue_s)/1024/1024) by ResourceId
         | join kind=inner (
             $disksTableName
-            | where TimeGenerated > ago(1d) and DiskState_s =~ 'Attached' and SKU_s startswith 'Premium'
+            | where TimeGenerated > ago(1d) and DiskState_s =~ 'Attached' and SKU_s startswith 'Premium' and SKU_s !contains "V2"
             | extend DiskTier_s = strcat(DiskTier_s, ' ', tostring(split(SKU_s, '_')[1]))
             | project ResourceId=InstanceId_s, DiskName_s, ResourceGroup = ResourceGroupName_s, SubscriptionId = SubscriptionGuid_g, Cloud_s, TenantGuid_g, Tags_s, MaxMBsDisk=toint(DiskThroughput_s), DiskSizeGB_s, SKU_s, DiskTier_s, DiskType_s
         ) on ResourceId