RFC - [DataGrid] Change how column options menu and filter are shown

[vnbaaij]

Current situation

With the DataGrid it is possible to use the ColumnOptions parameter to specify (usually) a filter for a column. In the current version, it looks like this (example comes from the demo site):

When a filter is applied, the indicator icon is changed to make clear this is a filtered column:

The ColumnOptions can potentially be used for more things (see PR #2238) and showing a filter icon does not make a lot of sense then.

Proposed change

I propose to change this so that when ColumnOptions are specified, a generic 'more' icon will be shown. When ColumnOptions allows for a filter to be applied, a filter indicator will be shown besides the title akin to to sort indicator:

When no filter is applied, no indicator will be shown of course (just as no sort indicator is shown when no sorting is taking place on a column)

Thoughts? Questions? Remarks?

[juanmangd]

What option can be though for the user to notice that there is a sorting capability on the column header in question? Filter may be obvious given the input field but sorting may not be that obvious

[vnbaaij]

The whole header cell, besides the filter button (now) or more button (after change) is a button when a column can be sorted. That is already the case now and won't change.

[dvoituron]

I think that's great. Just a few questions:

1. Shouldn't we take the opportunity to adapt the "sort" icon, to make it softer, like FluentUI React does:
   
2. I may have confused the vertical [...] indicator with the Column Resize icon. But I don't know which one to use. A "ChevronDownUp" or other chevron? :-)

[vnbaaij]

I think that's great. Just a few questions:

1. Shouldn't we take the opportunity to adapt the "sort" icon, to make it softer, like FluentUI React does:

Yes, we can certainly do that

2. I may have confused the vertical [...] indicator with the Column Resize icon. But I don't know which one to use. A "ChevronDownUp" or other chevron? :-)

I'll try some variations.

[vnbaaij]

Something more like this:

[dvoituron]

Personally, I find it clearer :-)

[vnbaaij]

Me too!