Skip to content

Commit 98eec6c

Browse files
samuelfreibergsamuelfreiberg
authored
WebDriverIO V8 Fixes (#3622)
* Adding resolutions to specific packages with security vulnerabilities * Remove * Adding whitespace * Revert * Removing unused file * Wdio to v8 * Remove dep * Fixing packages * Change files * Remove unnecessary code in tsconfig * Change files * Remove unnecessary code in tsconfig * Remove unnecessary code * Fixing tsconfig * Fixing ts * Adding tsconfig changes * Adding necessary dep
1 parent b709dc5 commit 98eec6c

File tree

11 files changed

+70
-13
lines changed

11 files changed

+70
-13
lines changed

‎apps/E2E/global.d.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

‎apps/E2E/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@
4141
"@types/react": "^18.2.0",
4242
"@wdio/appium-service": "8.29.1",
4343
"@wdio/cli": "8.35.1",
44+
"@wdio/globals": "8.35.1",
4445
"@wdio/jasmine-framework": "8.35.1",
46+
"@wdio/json-reporter": "8.32.4",
4547
"@wdio/local-runner": "8.35.1",
4648
"@wdio/spec-reporter": "8.32.4",
4749
"appium": "^2.5.1",

‎apps/E2E/src/common/BasePage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ export abstract class BasePage {
299299
const scrollDownKeys = [Keys.PAGE_DOWN];
300300
await browser.waitUntil(
301301
async () => {
302-
await FocusButton.addValue(scrollDownKeys);
302+
await FocusButton.addValue(scrollDownKeys.join());
303303
scrollDownKeys.push(Keys.PAGE_DOWN);
304304
return await ComponentToScrollTo.isDisplayed();
305305
},
@@ -313,7 +313,7 @@ export abstract class BasePage {
313313
);
314314

315315
// We have this extra scroll here to ensure the whole component is visible.
316-
await FocusButton.addValue(scrollDownKeys);
316+
await FocusButton.addValue(scrollDownKeys.join());
317317
}
318318

319319
/* Scrolls to the specified or primary UI test element until it is displayed. */

‎apps/E2E/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"*": ["*", "*.win32", "./*"],
99
"src/*": ["./src/*", "src"]
1010
},
11-
"types": ["./global", "webdriverio", "@wdio/jasmine-framework", "node", "@types/jasmine"]
11+
"types": ["@types/jasmine", "@wdio/globals/types", "@wdio/jasmine-framework", "node"]
1212
},
1313
"include": ["src"]
1414
}

‎apps/component-generator/component-templates/ComponentTemplate/src/__tests__/__snapshots__/ComponentName.test.tsx.snap

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
// Jest Snapshot v1, https://goo.gl/fbAQLP
2+
3+
exports[`ComponentName component tests ComponentName default 1`] = `
4+
<View
5+
style={
6+
{
7+
"alignItems": "center",
8+
"alignSelf": "flex-start",
9+
"backgroundColor": "#ffffff",
10+
"borderColor": "#0f6cbd",
11+
"display": "flex",
12+
"flexDirection": "row",
13+
"justifyContent": "center",
14+
}
15+
}
16+
>
17+
<Text
18+
ellipsizeMode="tail"
19+
numberOfLines={0}
20+
style={
21+
{
22+
"color": "#0f6cbd",
23+
"fontFamily": "Segoe UI",
24+
"fontSize": 13,
25+
"fontWeight": "400",
26+
"margin": 0,
27+
}
28+
}
29+
>
30+
Default text
31+
</Text>
32+
Your component
33+
</View>
34+
`;

‎apps/fluent-tester/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@
107107
"@rnx-kit/metro-config": "^1.3.1",
108108
"@types/jasmine": "5.1.4",
109109
"@wdio/cli": "8.35.1",
110+
"@wdio/globals": "8.35.1",
110111
"@wdio/jasmine-framework": "8.35.1",
111112
"flow-bin": "^0.113.0",
112113
"metro-config": "^0.80.0",

‎apps/fluent-tester/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"*": ["*", "*.win32", "./*"],
99
"src/*": ["./src/*", "src"]
1010
},
11-
"types": ["../E2E/global", "webdriverio", "@wdio/jasmine-framework", "node", "@types/jasmine"]
11+
"types": ["@types/jasmine", "@wdio/globals/types", "@wdio/jasmine-framework", "node"]
1212
},
1313
"include": ["src"]
1414
}

‎change/@fluentui-react-native-e2e-testing-e022d127-0016-4f43-b8b3-aa167c0e83dd.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "minor",
3+
"comment": "Wdio to v8",
4+
"packageName": "@fluentui-react-native/e2e-testing",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

‎change/@fluentui-react-native-tester-8c74c475-7f8d-4c6e-a621-d37730ba31eb.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "minor",
3+
"comment": "Remove unnecessary code in tsconfig",
4+
"packageName": "@fluentui-react-native/tester",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

‎tester_deps/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@
1717
"@types/react": "^18.2.0",
1818
"@wdio/appium-service": "8.29.1",
1919
"@wdio/cli": "8.35.1",
20+
"@wdio/globals": "8.35.1",
2021
"@wdio/jasmine-framework": "8.35.1",
22+
"@wdio/json-reporter": "8.32.4",
2123
"@wdio/local-runner": "8.35.1",
22-
"@wdio/logger": "8.28.0",
2324
"@wdio/spec-reporter": "8.32.4",
2425
"appium": "2.5.1",
2526
"appium-windows-driver": "^2.12.18",
2627
"ts-node": "^10.7.0",
2728
"typescript": "^4.9.4",
28-
"wdio-json-reporter": "3.0.0",
2929
"webdriverio": "8.35.1"
3030
},
3131
"resolutions": {

0 commit comments

Comments
 (0)