Change TextCtlSubtlePlaceholder to TextTextBoxPlaceholder (#3965)

* Remove another palette entry

* Change files

Author: rurikoaraki

change/@fluentui-react-native-theme-types-ea9e6263-6722-45bc-8a43-613225a1bcb4.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Remove another palette entry",
+  "packageName": "@fluentui-react-native/theme-types",
+  "email": "email not defined",
+  "dependentChangeType": "patch"
+}

change/@fluentui-react-native-win32-theme-d87e956f-e913-41cf-9c96-d0db336ed6d5.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Remove another palette entry",
+  "packageName": "@fluentui-react-native/win32-theme",
+  "email": "email not defined",
+  "dependentChangeType": "patch"
+}

packages/theming/theme-types/src/palette.types.ts

@@ -120,7 +120,6 @@ export interface OfficePalette {
 
   // text
   TextCtlSubtle: ColorValue;
-  TextCtlSubtlePlaceholder: ColorValue;
   TextCtlSubtleHover: ColorValue;
   TextCtlSubtlePressed: ColorValue;
   TextCtlSubtleDisabled: ColorValue;
@@ -254,4 +253,5 @@ export interface OfficePalette {
   BkgCtlSubtleFocus: ColorValue;
   BkgCtlSubtleHoverDisabled: ColorValue;
   BkgCtlSubtleSelectedDisabled: ColorValue;
+  TextTextBoxPlaceholder: ColorValue;
 }

packages/theming/win32-theme/src/NativeModule/fallbackOfficeModule.ts

@@ -68,7 +68,6 @@ const whiteColorsPalette: OfficePalette = {
   BkgCtlSubtlePressed: '#FFFFFF',
   BkgCtlSubtleDisabled: '#F3F3F3',
   TextCtlSubtle: '#262626',
-  TextCtlSubtlePlaceholder: '#666666',
   TextCtlSubtleHover: '#262626',
   TextCtlSubtlePressed: '#262626',
   TextCtlSubtleDisabled: '#B1B1B1',
@@ -140,6 +139,7 @@ const whiteColorsPalette: OfficePalette = {
   BkgCtlSubtleSelectedDisabled: '#F3F3F3',
   BkgHeader: '#E6E6E6',
   TextHeader: '#262626',
+  TextTextBoxPlaceholder: '#666666',
 };
 
 export function fallbackGetPalette(pal?: string): OfficePalette {

packages/theming/win32-theme/src/__tests__/__snapshots__/win32-theme.test.ts.snap

@@ -2835,7 +2835,6 @@ exports[`createOfficeTheme test 1`] = `
       "TextCtlSubtle": "#262626",
       "TextCtlSubtleDisabled": "#B1B1B1",
       "TextCtlSubtleHover": "#262626",
-      "TextCtlSubtlePlaceholder": "#666666",
       "TextCtlSubtlePressed": "#262626",
       "TextCtlSubtleSelected": "#262626",
       "TextDisabled": "#B1B1B1",
@@ -2863,6 +2862,7 @@ exports[`createOfficeTheme test 1`] = `
       "TextSecondarySelected": "#666666",
       "TextSelected": "#262626",
       "TextSelectionHighlight": "#FFFFFF",
+      "TextTextBoxPlaceholder": "#666666",
       "ThumbToggleSwitchOff": "#505050",
       "ThumbToggleSwitchOffDisabled": "#D2D2D2",
       "ThumbToggleSwitchOffHover": "#505050",
@@ -3318,7 +3318,6 @@ exports[`fallbackGetPalette test Random palette 1`] = `
   "TextCtlSubtle": "#262626",
   "TextCtlSubtleDisabled": "#B1B1B1",
   "TextCtlSubtleHover": "#262626",
-  "TextCtlSubtlePlaceholder": "#666666",
   "TextCtlSubtlePressed": "#262626",
   "TextCtlSubtleSelected": "#262626",
   "TextDisabled": "#B1B1B1",
@@ -3346,6 +3345,7 @@ exports[`fallbackGetPalette test Random palette 1`] = `
   "TextSecondarySelected": "#666666",
   "TextSelected": "#262626",
   "TextSelectionHighlight": "#FFFFFF",
+  "TextTextBoxPlaceholder": "#666666",
   "ThumbToggleSwitchOff": "#505050",
   "ThumbToggleSwitchOffDisabled": "#D2D2D2",
   "ThumbToggleSwitchOffHover": "#505050",
@@ -3460,7 +3460,6 @@ exports[`fallbackGetPalette test TaskPane palette 1`] = `
   "TextCtlSubtle": "#262626",
   "TextCtlSubtleDisabled": "#B1B1B1",
   "TextCtlSubtleHover": "#262626",
-  "TextCtlSubtlePlaceholder": "#666666",
   "TextCtlSubtlePressed": "#262626",
   "TextCtlSubtleSelected": "#262626",
   "TextDisabled": "#B1B1B1",
@@ -3488,6 +3487,7 @@ exports[`fallbackGetPalette test TaskPane palette 1`] = `
   "TextSecondarySelected": "#666666",
   "TextSelected": "#262626",
   "TextSelectionHighlight": "#FFFFFF",
+  "TextTextBoxPlaceholder": "#666666",
   "ThumbToggleSwitchOff": "#505050",
   "ThumbToggleSwitchOffDisabled": "#D2D2D2",
   "ThumbToggleSwitchOffHover": "#505050",

packages/theming/win32-theme/src/createAliasesFromPalette.ts

@@ -16,7 +16,7 @@ export function createAliasesFromPalette(palette: OfficePalette, isHighContrast:
     neutralForeground2Hover: palette.TextSecondaryHover,
     neutralForeground2Pressed: palette.TextSecondaryPressed,
     neutralForeground2Selected: palette.TextSecondarySelected,
-    neutralForeground4: palette.TextCtlSubtlePlaceholder,
+    neutralForeground4: palette.TextTextBoxPlaceholder,
     neutralForegroundDisabled: palette.TextDisabled,
 
     compoundBrandForeground1: palette.TextEmphasis,

packages/theming/win32-theme/src/paletteFromOfficeColors.ts

@@ -24,7 +24,7 @@ export function paletteFromOfficeColors(p: OfficePalette): Palette {
     inputBackground: p.BkgCtlSubtle,
     inputFocusBorderAlt: p.StrokeCtlSubtleKeyboard,
     inputText: p.TextCtlSubtle,
-    inputPlaceholderText: p.TextCtlSubtlePlaceholder,
+    inputPlaceholderText: p.TextTextBoxPlaceholder,
 
     buttonBackground: p.BkgCtl,
     buttonBackgroundChecked: p.BkgCtlSelected,