Skip to content

Commit 9420f34

Browse files
authored
fix(web-components): ensure menu initialization is queued (#35328)
1 parent 6c4630f commit 9420f34

File tree

4 files changed

+13
-2
lines changed

4 files changed

+13
-2
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "fix(web-components): ensure menu initialization is queued",
4+
"packageName": "@fluentui/web-components",
5+
"email": "863023+radium-v@users.noreply.github.com",
6+
"dependentChangeType": "patch"
7+
}

packages/web-components/src/menu/menu.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ test.describe('Menu', () => {
284284
await fastPage.setTemplate(/* html */ `
285285
<fluent-menu>
286286
<fluent-menu-button appearance="primary" slot="trigger" icon-only></fluent-menu-button>
287-
<fluent-button appearance="primary" slot="primary-action">Primary Action</fluent-menu-button>
287+
<fluent-button appearance="primary" slot="primary-action">Primary Action</fluent-button>
288288
<fluent-menu-list>
289289
<fluent-menu-item>
290290
Item 1

packages/web-components/src/menu/menu.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,9 @@ export class Menu extends FASTElement {
129129
*/
130130
public connectedCallback() {
131131
super.connectedCallback();
132-
Updates.enqueue(() => this.setComponent());
132+
queueMicrotask(() => {
133+
this.setComponent();
134+
});
133135
}
134136

135137
/**

packages/web-components/src/tabs/tabs.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,8 @@ test.describe('Tabs', () => {
327327
node.disabled = true;
328328
});
329329

330+
await expect(secondTab).toBeDisabled();
331+
330332
// eslint-disable-next-line playwright/no-force-option
331333
await secondTab.click({ force: true });
332334

0 commit comments

Comments
 (0)