Uncalled `expect(name).not.toBeFalsy;` in test code

[RyanCavanaugh]

fluentui/packages/utilities/src/object.test.ts

Line 49 in dab45a2

expect(name).not.toBeFalsy;

We're wondering if this was intentional or not - it's a bit odd since name definitely is falsy in this codepath, so while it looks like a simple mistaken uncalled function, this function call appears that it would throw. OTOH maybe that's why the error wasn't detected?

[RyanCavanaugh]

ref. microsoft/TypeScript#47719

[spmonahan]

Disclaimer: this is the first time I've looked at this particular code :)

I read this as a "fail fast" path in the test and I'm not sure this is strictly necessary so I'll investigate it some more.

However, I do feel confident in saying that the line in question should be expect(name).not.toBeFalsy(); (i.e., toBeFalsy() needs to be called).

[spmonahan]

After looking some more I've opened this PR: #22533