Fix INFO all/default/everything returning empty response (#1645)

* Fix INFO all/default/everything returning empty response

Implement support for INFO all, default, and everything options:
- all: returns all DefaultInfo sections excluding module-generated ones
- default: returns the default set of sections (same as no-arg INFO)
- everything: returns all DefaultInfo sections including modules

Added pre-declared HashSet collections (AllInfoSet, EverythingInfoSet)
in GarnetInfoMetrics.cs derived from DefaultInfo to support these options.

Updated InfoCommand.cs to use UnionWith with the new HashSets instead of
silently skipping the ALL keyword.

Added tests for all three options, verifying correct section inclusion/exclusion.

Fixes #1643

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* make everything option use DefaultInfo

* Add null/empty guard in GetSectionHeaders test helper

Adds explicit asserts before splitting INFO output so test failures
surface a clear message instead of a NullReferenceException.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* wip; restructuring cluster tests to reduce CI duration

* separate dispose from close and configure socket to allow rapid connect

* ensure socket is disposed succesfully

* fix failing test

* update global.json

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: vazois

benchmark/BDN.benchmark/Embedded/GarnetServerEmbedded.cs

@@ -110,6 +110,11 @@ public override void Start()
         {
         }
 
+        /// <inheritdoc />
+        public override void Close()
+        {
+        }
+
         public bool TryCreateMessageConsumer(Span<byte> bytes, INetworkSender networkSender, out IMessageConsumer session)
         {
             session = null;

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "10.0.103",
+    "version": "10.0.201",
     "rollForward": "latestMajor",
     "allowPrerelease": false
   }

libs/host/GarnetServer.cs

@@ -478,7 +478,14 @@ public void Dispose(bool deleteDir = true)
 
         private void InternalDispose()
         {
+            // Phase 1: Stop listening on all servers to free ports immediately.
+            for (var i = 0; i < servers.Length; i++)
+                servers[i]?.Close();
+
+            // Phase 2: Dispose the provider (storage engine shutdown — may take time).
             Provider?.Dispose();
+
+            // Phase 3: Drain active handlers and clean up remaining resources.
             for (var i = 0; i < servers.Length; i++)
                 servers[i]?.Dispose();
             subscribeBroker?.Dispose();

libs/server/Lua/LuaTimeoutManager.cs

@@ -263,7 +263,7 @@ internal Registration RegisterForTimeout(SessionScriptCache cache)
                 goto tryAgain;
             }
 
-        // Other threads might update registrations, so check that before returning
+            // Other threads might update registrations, so check that before returning
         checkUnmodified:
             if ((updatedRegistrations = Interlocked.CompareExchange(ref registrations, curRegistrations, curRegistrations)) != curRegistrations)
             {

libs/server/Metrics/Info/GarnetInfoMetrics.cs

@@ -25,6 +25,11 @@ class GarnetInfoMetrics
                 _ => true
             })];
 
+        /// <summary>
+        /// All info sections excluding module-generated ones.
+        /// </summary>
+        public static readonly HashSet<InfoMetricsType> AllInfoSet = [.. DefaultInfo.Where(e => e != InfoMetricsType.MODULES)];
+
         MetricsItem[] serverInfo = null;
         MetricsItem[] memoryInfo = null;
         MetricsItem[] clusterInfo = null;

libs/server/Metrics/Info/InfoCommand.cs

@@ -28,17 +28,20 @@ private bool NetworkINFO()
                         reset = true;
                     else if (sbSection.EqualsUpperCaseSpanIgnoringCase("HELP"u8))
                         help = true;
-                    else if (!sbSection.EqualsUpperCaseSpanIgnoringCase("ALL"u8))
+                    else if (sbSection.EqualsUpperCaseSpanIgnoringCase("ALL"u8))
+                        sections.UnionWith(GarnetInfoMetrics.AllInfoSet);
+                    else if (sbSection.EqualsUpperCaseSpanIgnoringCase("DEFAULT"u8))
+                        sections.UnionWith(GarnetInfoMetrics.DefaultInfo);
+                    else if (sbSection.EqualsUpperCaseSpanIgnoringCase("EVERYTHING"u8))
+                        sections.UnionWith(GarnetInfoMetrics.DefaultInfo);
+                    else if (parseState.TryGetInfoMetricsType(i, out var sectionType))
                     {
-                        if (parseState.TryGetInfoMetricsType(i, out var sectionType))
-                        {
-                            sections.Add(sectionType);
-                        }
-                        else
-                        {
-                            invalid = true;
-                            invalidSection = parseState.GetString(i);
-                        }
+                        sections.Add(sectionType);
+                    }
+                    else
+                    {
+                        invalid = true;
+                        invalidSection = parseState.GetString(i);
                     }
                 }
             }

libs/server/Metrics/Info/InfoHelp.cs

@@ -10,6 +10,8 @@ class InfoHelp
     {
         internal const string HELP = "HELP";
         internal const string ALL = "ALL";
+        internal const string DEFAULT = "DEFAULT";
+        internal const string EVERYTHING = "EVERYTHING";
         internal const string RESET = "RESET";
 
         public static List<string> GetInfoTypeHelpMessage()
@@ -33,7 +35,9 @@ public static List<string> GetInfoTypeHelpMessage()
                 $"{nameof(InfoMetricsType.KEYSPACE)}: Database related statistics.",
                 $"{nameof(InfoMetricsType.MODULES)}: Information related to loaded modules.",
                 $"{nameof(InfoMetricsType.HLOGSCAN)}: Distribution of records in main store's hybrid log in-memory portion.",
-                $"{nameof(ALL)}: Return all informational sections.",
+                $"{nameof(ALL)}: Return all informational sections (excluding module generated ones).",
+                $"{nameof(DEFAULT)}: Return the default set of informational sections.",
+                $"{nameof(EVERYTHING)}: Return all informational sections including module generated ones.",
                 $"{nameof(HELP)}: Print this help message.",
                 $"{nameof(RESET)}: Reset stats.",
                 "\r\n",

libs/server/Servers/GarnetServerBase.cs

@@ -154,6 +154,9 @@ public bool AddSession(WireFormat protocol, ref ISessionProvider provider, INetw
         /// <inheritdoc />
         public abstract void Start();
 
+        /// <inheritdoc />
+        public abstract void Close();
+
         /// <inheritdoc />
         public virtual void Dispose()
         {

libs/server/Servers/GarnetServerTcp.cs

@@ -82,24 +82,47 @@ public GarnetServerTcp(
             this.unixSocketPath = unixSocketPath;
             this.unixSocketPermission = unixSocketPermission;
 
-            listenSocket = endpoint switch
+            if (endpoint is UnixDomainSocketEndPoint unix)
             {
-                UnixDomainSocketEndPoint unix => new Socket(unix.AddressFamily, SocketType.Stream, ProtocolType.Unspecified),
+                // UDS Initialization & Cleanup
+                listenSocket = new Socket(unix.AddressFamily, SocketType.Stream, ProtocolType.Unspecified);
+                var socketPath = unix.ToString();
+                if (File.Exists(socketPath))
+                {
+                    File.Delete(socketPath);
+                }
+            }
+            else
+            {
+                // TCP Initialization & Port Reuse
+                listenSocket = new Socket(endpoint.AddressFamily, SocketType.Stream, ProtocolType.Tcp);
 
-                _ => new Socket(endpoint.AddressFamily, SocketType.Stream, ProtocolType.Tcp)
-            };
+                // Set reuse BEFORE Bind to handle TIME_WAIT states
+                listenSocket.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.ReuseAddress, true);
+            }
 
             acceptEventArg = new SocketAsyncEventArgs();
             acceptEventArg.Completed += AcceptEventArg_Completed;
         }
 
+        /// <summary>
+        /// Stop listening for new connections. Frees the listening port
+        /// without waiting for active connections to drain.
+        /// </summary>
+        public override void Close()
+        {
+            listenSocket.Close();
+        }
+
         /// <summary>
         /// Dispose
         /// </summary>
         public override void Dispose()
         {
-            base.Dispose();
+            // Close listening socket to free the port and stop accepting new connections.
+            // This also prevents new connections from arriving while DisposeActiveHandlers drains existing ones.
             listenSocket.Dispose();
+            base.Dispose();
             acceptEventArg.UserToken = null;
             acceptEventArg.Dispose();
             networkPool?.Dispose();

libs/server/Servers/IGarnetServer.cs

@@ -46,5 +46,11 @@ public interface IGarnetServer : IDisposable
         /// Start server
         /// </summary>
         public void Start();
+
+        /// <summary>
+        /// Stop listening for new connections. Frees the listening port
+        /// without waiting for active connections to drain.
+        /// </summary>
+        public void Close();
     }
 }