expose last failover status

Author: vazois

libs/cluster/Server/ClusterProvider.cs

@@ -253,7 +253,8 @@ public MetricsItem[] GetReplicationInfo()
                     replicationInfo.Add(new("master_sync_last_io_seconds_ago", replicationManager.LastPrimarySyncSeconds.ToString()));
                     replicationInfo.Add(new("replication_offset_lag", replicationOffsetLag.ToString()));
                     replicationInfo.Add(new("replication_offset_max_lag", storeWrapper.serverOptions.ReplicationOffsetMaxLag.ToString()));
-                    replicationInfo.Add(new("recoverStatus", replicationManager.recoverStatus.ToString()));
+                    replicationInfo.Add(new("recover_status", replicationManager.recoverStatus.ToString()));
+                    replicationInfo.Add(new("last_failover_state", !clusterEnabled ? FailoverUtils.GetFailoverStatus(FailoverStatus.NO_FAILOVER) : failoverManager.GetLastFailoverStatus()));
                 }
                 else
                 {

libs/cluster/Server/Failover/FailoverManager.cs

@@ -16,6 +16,7 @@ internal sealed class FailoverManager(ClusterProvider clusterProvider, ILogger l
         readonly TimeSpan clusterTimeout = clusterProvider.serverOptions.ClusterTimeout <= 0 ? Timeout.InfiniteTimeSpan : TimeSpan.FromSeconds(clusterProvider.serverOptions.ClusterTimeout);
         readonly ILogger logger = logger;
         private SingleWriterMultiReaderLock failoverTaskLock;
+        public FailoverStatus lastFailoverStatus = FailoverStatus.NO_FAILOVER;
 
         public void Dispose()
         {
@@ -46,6 +47,12 @@ public string GetFailoverStatus()
                 FailoverUtils.GetFailoverStatus(FailoverStatus.NO_FAILOVER);
         }
 
+        /// <summary>
+        /// Retrieve the status of the last failover
+        /// </summary>
+        /// <returns></returns>
+        public string GetLastFailoverStatus() => FailoverUtils.GetFailoverStatus(lastFailoverStatus);
+
         /// <summary>
         /// Method used to initiate a background failover from a replica (CLUSTER FAILOVER command)
         /// </summary>
@@ -66,7 +73,8 @@ public bool TryStartReplicaFailover(FailoverOption option, TimeSpan failoverTime
                 logger: logger);
             _ = Task.Run(async () =>
             {
-                _ = await currentFailoverSession.BeginAsyncReplicaFailover();
+                var success = await currentFailoverSession.BeginAsyncReplicaFailover();
+                lastFailoverStatus = success ? FailoverStatus.FAILOVER_COMPLETED : FailoverStatus.FAILOVER_ABORTED;
                 Reset();
             });
             return true;

libs/cluster/Server/Failover/FailoverStatus.cs

@@ -15,7 +15,9 @@ internal enum FailoverStatus : byte
         ISSUING_PAUSE_WRITES,
         WAITING_FOR_SYNC,
         FAILOVER_IN_PROGRESS,
-        TAKING_OVER_AS_PRIMARY
+        TAKING_OVER_AS_PRIMARY,
+        FAILOVER_COMPLETED,
+        FAILOVER_ABORTED
     }
 
     internal static class FailoverUtils
@@ -36,6 +38,8 @@ public static string GetFailoverStatus(FailoverStatus? status)
                 FailoverStatus.WAITING_FOR_SYNC => "waiting-for-sync",
                 FailoverStatus.FAILOVER_IN_PROGRESS => "failover-in-progress",
                 FailoverStatus.TAKING_OVER_AS_PRIMARY => "taking-over-as-primary",
+                FailoverStatus.FAILOVER_COMPLETED => "failover-completed",
+                FailoverStatus.FAILOVER_ABORTED => "failover-aborted",
                 _ => throw new Exception("invalid failover status"),
             };
         }