builtin/shortlog: fix various trivial memory leaks

pks-t · gitster · commit 06da42beec11 · 2024-08-01T08:47:37.000-07:00
There is a trivial memory leak in git-shortlog(1). Fix it.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/shortlog.c b/builtin/shortlog.c
@@ -514,4 +514,5 @@ void shortlog_output(struct shortlog *log)
 	string_list_clear(&log->list, 1);
 	clear_mailmap(&log->mailmap);
 	string_list_clear(&log->format, 0);
+	string_list_clear(&log->trailers, 0);
 }
diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh
@@ -9,6 +9,7 @@ test_description='git shortlog
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success 'setup' '

Original file line number	Diff line number	Diff line change
`@@ -514,4 +514,5 @@ void shortlog_output(struct shortlog *log)`
`514`	`514`	`string_list_clear(&log->list, 1);`
`515`	`515`	`clear_mailmap(&log->mailmap);`
`516`	`516`	`string_list_clear(&log->format, 0);`
	`517`	`+ string_list_clear(&log->trailers, 0);`
`517`	`518`	`}`