Merge branch 'rs/clear-commit-marks-optim'

gitster · gitster · commit 16b2e579f91c · 2025-02-27T15:23:00.000-08:00
A micro-optimization.

* rs/clear-commit-marks-optim:
  commit: avoid parent list buildup in clear_commit_marks_many()
diff --git a/commit.c b/commit.c
@@ -780,14 +780,14 @@ static void clear_commit_marks_1(struct commit_list **plist,
 
 void clear_commit_marks_many(size_t nr, struct commit **commit, unsigned int mark)
 {
-	struct commit_list *list = NULL;
-
 	for (size_t i = 0; i < nr; i++) {
+		struct commit_list *list = NULL;
+
 		clear_commit_marks_1(&list, *commit, mark);
+		while (list)
+			clear_commit_marks_1(&list, pop_commit(&list), mark);
 		commit++;
 	}
-	while (list)
-		clear_commit_marks_1(&list, pop_commit(&list), mark);
 }
 
 void clear_commit_marks(struct commit *commit, unsigned int mark)

Original file line number	Diff line number	Diff line change
`@@ -780,14 +780,14 @@ static void clear_commit_marks_1(struct commit_list **plist,`
`780`	`780`
`781`	`781`	`void clear_commit_marks_many(size_t nr, struct commit **commit, unsigned int mark)`
`782`	`782`	`{`
`783`		`- struct commit_list *list = NULL;`
`784`		`-`
`785`	`783`	`for (size_t i = 0; i < nr; i++) {`
	`784`	`+ struct commit_list *list = NULL;`
	`785`	`+`
`786`	`786`	`clear_commit_marks_1(&list, *commit, mark);`
	`787`	`+ while (list)`
	`788`	`+ clear_commit_marks_1(&list, pop_commit(&list), mark);`
`787`	`789`	`commit++;`
`788`	`790`	`}`
`789`		`- while (list)`
`790`		`- clear_commit_marks_1(&list, pop_commit(&list), mark);`
`791`	`791`	`}`
`792`	`792`
`793`	`793`	`void clear_commit_marks(struct commit *commit, unsigned int mark)`