builtin/credential-store: fix leaking credential

pks-t · gitster · commit 1d615afa8d52 · 2024-08-01T08:47:36.000-07:00
We never free credentials read by the credential store, leading to a
memory leak. Plug it.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/credential-store.c b/builtin/credential-store.c
@@ -218,5 +218,6 @@ int cmd_credential_store(int argc, const char **argv, const char *prefix)
 		; /* Ignore unknown operation. */
 
 	string_list_clear(&fns, 0);
+	credential_clear(&c);
 	return 0;
 }
diff --git a/t/t0302-credential-store.sh b/t/t0302-credential-store.sh
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='credential-store tests'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-credential.sh
 
diff --git a/t/t0303-credential-external.sh b/t/t0303-credential-external.sh
@@ -29,6 +29,7 @@ you can set GIT_TEST_CREDENTIAL_HELPER_SETUP to a sequence of shell
 commands.
 '
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-credential.sh
 

Original file line number	Diff line number	Diff line change
`@@ -218,5 +218,6 @@ int cmd_credential_store(int argc, const char *argv, const char prefix)`
`218`	`218`	`; /* Ignore unknown operation. */`
`219`	`219`
`220`	`220`	`string_list_clear(&fns, 0);`
	`221`	`+ credential_clear(&c);`
`221`	`222`	`return 0;`
`222`	`223`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ you can set GIT_TEST_CREDENTIAL_HELPER_SETUP to a sequence of shell`
`29`	`29`	`commands.`
`30`	`30`	`'`
`31`	`31`
	`32`	`+TEST_PASSES_SANITIZE_LEAK=true`
`32`	`33`	`. ./test-lib.sh`
`33`	`34`	`. "$TEST_DIRECTORY"/lib-credential.sh`
`34`	`35`