Skip to content

Commit 38283bc

Browse files
newrenchriscool
authored andcommitted
replay: add an important FIXME comment about gpg signing
We want to be able to handle signed commits in some way in the future, but we are not ready to do it now. So for the time being let's just add a FIXME comment to remind us about it. These are different ways we could handle them: - in case of a cli user and if there was an interactive mode, we could perhaps ask if the user wants to sign again - we could add an option to just fail if there are signed commits Co-authored-by: Christian Couder <[email protected]> Signed-off-by: Elijah Newren <[email protected]> Signed-off-by: Christian Couder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 8259e41 commit 38283bc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

builtin/replay.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ static struct commit *create_commit(struct tree *tree,
6262
struct object *obj;
6363
struct commit_list *parents = NULL;
6464
char *author;
65-
char *sign_commit = NULL;
65+
char *sign_commit = NULL; /* FIXME: cli users might want to sign again */
6666
struct commit_extra_header *extra;
6767
struct strbuf msg = STRBUF_INIT;
6868
const char *out_enc = get_commit_output_encoding();

0 commit comments

Comments
 (0)