Skip to content

Commit 463a2be

Browse files
jeffhostetlermjcheetham
authored andcommitted
gvfs-helper: create tool to fetch objects using the GVFS Protocol
Create gvfs-helper. This is a helper tool to use the GVFS Protocol REST API to fetch objects and configuration data from a GVFS cache-server or Git server. This tool uses libcurl to send object requests to either server. This tool creates loose objects and/or packfiles. Create gvfs-helper-client. This code resides within git proper and uses the sub-process API to manage gvfs-helper as a long-running background process. Signed-off-by: Jeff Hostetler <[email protected]> Signed-off-by: Derrick Stolee <[email protected]>
1 parent bdd8bcb commit 463a2be

17 files changed

+2874
-3
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@
7474
/git-gc
7575
/git-get-tar-commit-id
7676
/git-grep
77+
/git-gvfs-helper
7778
/git-hash-object
7879
/git-help
7980
/git-hook

Documentation/config.adoc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,8 @@ include::config/gui.adoc[]
448448

449449
include::config/guitool.adoc[]
450450

451+
include::config/gvfs.adoc[]
452+
451453
include::config/help.adoc[]
452454

453455
include::config/http.adoc[]

Documentation/config/core.adoc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -787,6 +787,9 @@ core.gvfs::
787787
flag just blocks them from occurring at all.
788788
--
789789

790+
core.useGvfsHelper::
791+
TODO
792+
790793
core.sparseCheckout::
791794
Enable "sparse checkout" feature. See linkgit:git-sparse-checkout[1]
792795
for more information.

Documentation/config/gvfs.adoc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
gvfs.cache-server::
2+
TODO
3+
4+
gvfs.sharedcache::
5+
TODO

Documentation/lint-manpages.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ check_missing_docs () (
2727
git-init-db) continue;;
2828
git-remote-*) continue;;
2929
git-stage) continue;;
30+
git-gvfs-helper) continue;;
3031
git-legacy-*) continue;;
3132
git-?*--?* ) continue ;;
3233
esac

Makefile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,6 +1047,7 @@ LIB_OBJS += gpg-interface.o
10471047
LIB_OBJS += graph.o
10481048
LIB_OBJS += grep.o
10491049
LIB_OBJS += gvfs.o
1050+
LIB_OBJS += gvfs-helper-client.o
10501051
LIB_OBJS += hash-lookup.o
10511052
LIB_OBJS += hashmap.o
10521053
LIB_OBJS += help.o
@@ -1697,6 +1698,8 @@ endif
16971698
endif
16981699
BASIC_CFLAGS += $(CURL_CFLAGS)
16991700

1701+
PROGRAM_OBJS += gvfs-helper.o
1702+
17001703
REMOTE_CURL_PRIMARY = git-remote-http$X
17011704
REMOTE_CURL_ALIASES = git-remote-https$X git-remote-ftp$X git-remote-ftps$X
17021705
REMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)
@@ -2970,6 +2973,10 @@ scalar$X: scalar.o GIT-LDFLAGS $(GITLIBS)
29702973
$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) \
29712974
$(filter %.o,$^) $(LIBS)
29722975

2976+
git-gvfs-helper$X: gvfs-helper.o http.o GIT-LDFLAGS $(GITLIBS) $(LAZYLOAD_LIBCURL_OBJ)
2977+
$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
2978+
$(CURL_LIBCURL) $(EXPAT_LIBEXPAT) $(LIBS)
2979+
29732980
$(LIB_FILE): $(LIB_OBJS)
29742981
$(QUIET_AR)$(RM) $@ && $(AR) $(ARFLAGS) $@ $^
29752982

config.c

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
#include "wildmatch.h"
4545
#include "ws.h"
4646
#include "write-or-die.h"
47+
#include "transport.h"
4748

4849
struct config_source {
4950
struct config_source *prev;
@@ -1623,6 +1624,11 @@ int git_default_core_config(const char *var, const char *value,
16231624
return 0;
16241625
}
16251626

1627+
if (!strcmp(var, "core.usegvfshelper")) {
1628+
core_use_gvfs_helper = git_config_bool(var, value);
1629+
return 0;
1630+
}
1631+
16261632
if (!strcmp(var, "core.sparsecheckout")) {
16271633
/* virtual file system relies on the sparse checkout logic so force it on */
16281634
if (core_virtualfilesystem)
@@ -1774,6 +1780,39 @@ static int git_default_mailmap_config(const char *var, const char *value)
17741780
return 0;
17751781
}
17761782

1783+
static int git_default_gvfs_config(const char *var, const char *value)
1784+
{
1785+
if (!strcmp(var, "gvfs.cache-server")) {
1786+
char *v2 = NULL;
1787+
1788+
if (!git_config_string(&v2, var, value) && v2 && *v2) {
1789+
free(gvfs_cache_server_url);
1790+
gvfs_cache_server_url = transport_anonymize_url(v2);
1791+
}
1792+
free(v2);
1793+
return 0;
1794+
}
1795+
1796+
if (!strcmp(var, "gvfs.sharedcache") && value && *value) {
1797+
struct strbuf buf = STRBUF_INIT;
1798+
strbuf_addstr(&buf, value);
1799+
if (strbuf_normalize_path(&buf) < 0) {
1800+
/*
1801+
* Pretend it wasn't set. This will cause us to
1802+
* fallback to ".git/objects" effectively.
1803+
*/
1804+
strbuf_release(&buf);
1805+
return 0;
1806+
}
1807+
strbuf_trim_trailing_dir_sep(&buf);
1808+
1809+
gvfs_shared_cache_pathname = strbuf_detach(&buf, NULL);
1810+
return 0;
1811+
}
1812+
1813+
return 0;
1814+
}
1815+
17771816
static int git_default_attr_config(const char *var, const char *value)
17781817
{
17791818
if (!strcmp(var, "attr.tree")) {
@@ -1841,6 +1880,9 @@ int git_default_config(const char *var, const char *value,
18411880
if (starts_with(var, "sparse."))
18421881
return git_default_sparse_config(var, value);
18431882

1883+
if (starts_with(var, "gvfs."))
1884+
return git_default_gvfs_config(var, value);
1885+
18441886
/* Add other config variables here and to Documentation/config.adoc. */
18451887
return 0;
18461888
}

contrib/buildsystems/CMakeLists.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ if(NOT CURL_FOUND)
635635
add_compile_definitions(NO_CURL)
636636
message(WARNING "git-http-push and git-http-fetch will not be built")
637637
else()
638-
list(APPEND PROGRAMS_BUILT git-http-fetch git-http-push git-imap-send git-remote-http)
638+
list(APPEND PROGRAMS_BUILT git-http-fetch git-http-push git-imap-send git-remote-http git-gvfs-helper)
639639
if(CURL_VERSION_STRING VERSION_GREATER_EQUAL 7.34.0)
640640
add_compile_definitions(USE_CURL_FOR_IMAP_SEND)
641641
endif()
@@ -823,6 +823,9 @@ if(CURL_FOUND)
823823
add_executable(git-http-push ${CMAKE_SOURCE_DIR}/http-push.c)
824824
target_link_libraries(git-http-push http_obj common-main ${CURL_LIBRARIES} ${EXPAT_LIBRARIES})
825825
endif()
826+
827+
add_executable(git-gvfs-helper ${CMAKE_SOURCE_DIR}/gvfs-helper.c)
828+
target_link_libraries(git-gvfs-helper http_obj common-main ${CURL_LIBRARIES} )
826829
endif()
827830

828831
parse_makefile_for_executables(git_builtin_extra "BUILT_INS")

environment.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,9 @@ int protect_hfs = PROTECT_HFS_DEFAULT;
9898
#define PROTECT_NTFS_DEFAULT 1
9999
#endif
100100
int protect_ntfs = PROTECT_NTFS_DEFAULT;
101+
int core_use_gvfs_helper;
102+
char *gvfs_cache_server_url;
103+
const char *gvfs_shared_cache_pathname;
101104

102105
/*
103106
* The character that begins a commented line in user-editable file

environment.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,9 @@ extern int core_gvfs;
164164
extern int precomposed_unicode;
165165
extern int protect_hfs;
166166
extern int protect_ntfs;
167+
extern int core_use_gvfs_helper;
168+
extern char *gvfs_cache_server_url;
169+
extern const char *gvfs_shared_cache_pathname;
167170

168171
extern int core_apply_sparse_checkout;
169172
extern int core_sparse_checkout_cone;

0 commit comments

Comments
 (0)