Skip to content

Commit 4756494

Browse files
peffgitster
authored andcommitted
pack-bitmap: drop unused parameters from select_pseudo_merges()
We take the array of indexed_commits (and its length), but there's no need. The selection is based on ref reachability, not the linearized set of commits we're packing. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent ecc6fa9 commit 4756494

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

pack-bitmap-write.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,7 @@ void bitmap_writer_select_commits(struct bitmap_writer *writer,
737737

738738
stop_progress(&writer->progress);
739739

740-
select_pseudo_merges(writer, indexed_commits, indexed_commits_nr);
740+
select_pseudo_merges(writer);
741741
}
742742

743743

pseudo-merge.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -425,8 +425,7 @@ static void sort_pseudo_merge_matches(struct pseudo_merge_matches *matches)
425425
QSORT(matches->unstable, matches->unstable_nr, commit_date_cmp);
426426
}
427427

428-
void select_pseudo_merges(struct bitmap_writer *writer,
429-
struct commit **commits, size_t commits_nr)
428+
void select_pseudo_merges(struct bitmap_writer *writer)
430429
{
431430
struct progress *progress = NULL;
432431
uint32_t i;

pseudo-merge.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ struct pseudo_merge_commit_idx {
9595
*
9696
* Optionally shows a progress meter.
9797
*/
98-
void select_pseudo_merges(struct bitmap_writer *writer,
99-
struct commit **commits, size_t commits_nr);
98+
void select_pseudo_merges(struct bitmap_writer *writer);
10099

101100
/*
102101
* Represents a serialized view of a file containing pseudo-merge(s)

0 commit comments

Comments
 (0)