diff --color-moved: fix a memory leak

phillipwood · gitster · commit 47cb16a26447 · 2018-10-04T22:48:21.000-07:00
Free the hashmap items as well as the hashmap itself. This was found
with asan.

Signed-off-by: Phillip Wood &lt;phillip.wood@dunelm.org.uk&gt;
Reviewed-by: Stefan Beller &lt;sbeller@google.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/diff.c b/diff.c
@@ -5852,8 +5852,8 @@ static void diff_flush_patch_all_file_pairs(struct diff_options *o)
 			if (o->color_moved == COLOR_MOVED_ZEBRA_DIM)
 				dim_moved_lines(o);
 
-			hashmap_free(&add_lines, 0);
-			hashmap_free(&del_lines, 0);
+			hashmap_free(&add_lines, 1);
+			hashmap_free(&del_lines, 1);
 		}
 
 		for (i = 0; i < esm.nr; i++)

Original file line number	Diff line number	Diff line change
`@@ -5852,8 +5852,8 @@ static void diff_flush_patch_all_file_pairs(struct diff_options *o)`
`5852`	`5852`	`if (o->color_moved == COLOR_MOVED_ZEBRA_DIM)`
`5853`	`5853`	`dim_moved_lines(o);`
`5854`	`5854`
`5855`		`- hashmap_free(&add_lines, 0);`
`5856`		`- hashmap_free(&del_lines, 0);`
	`5855`	`+ hashmap_free(&add_lines, 1);`
	`5856`	`+ hashmap_free(&del_lines, 1);`
`5857`	`5857`	`}`
`5858`	`5858`
`5859`	`5859`	`for (i = 0; i < esm.nr; i++)`