fixup! scalar diagnose: include shared cache info

dscho · dscho · commit 5b64d5028299 · 2025-08-05T16:59:26.000+02:00
diff --git a/diagnose.c b/diagnose.c
@@ -332,7 +332,7 @@ int create_diagnostics_archive(struct repository *r,
 					res = error_errno(_("could not read '%s'"), path.buf);
 					goto diagnose_cleanup;
 				}
-				strvec_push(&archiver_args, buf.buf);
+				strvec_push(&archiver_args, buf.buf); // CodeQL [SM01932] justification: CodeQL is wrong here because the value is read from a file via strbuf_read() which does NUL-terminate the string, something CodeQL fails to understand
 			}
 			closedir(dir);
 		}

Original file line number	Diff line number	Diff line change
`@@ -332,7 +332,7 @@ int create_diagnostics_archive(struct repository *r,`
`332`	`332`	`res = error_errno(_("could not read '%s'"), path.buf);`
`333`	`333`	`goto diagnose_cleanup;`
`334`	`334`	`}`
`335`		`- strvec_push(&archiver_args, buf.buf);`
	`335`	`+ strvec_push(&archiver_args, buf.buf); // CodeQL [SM01932] justification: CodeQL is wrong here because the value is read from a file via strbuf_read() which does NUL-terminate the string, something CodeQL fails to understand`
`336`	`336`	`}`
`337`	`337`	`closedir(dir);`
`338`	`338`	`}`