Skip to content

Commit 6a748c2

Browse files
avargitster
authored andcommitted
mktag tests: invert --no-strict test
Change the mktag --no-strict test to actually test success under --no-strict, that test was added in 06ce791 (mktag: add a --[no-]strict option, 2021-01-06). It doesn't make sense to check that we have the same failure except when we want --no-strict, by doing that we're assuming that the behavior will be different under --no-strict, bun nothing was testing for that. We should instead assert that --strict is the same as --no-strict, except in the cases where we've declared that it's not. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent fce3b08 commit 6a748c2

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

t/t3800-mktag.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ check_verify_failure () {
3333
then
3434
test_must_fail git mktag <tag.sig 2>err2 &&
3535
test_cmp err err2
36+
else
37+
git mktag --no-strict <tag.sig
3638
fi
3739
'
3840
}

0 commit comments

Comments
 (0)