You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fetch: silence a CodeQL alert about a local variable's address' use after release
As pointed out by CodeQL, it is a potentially dangerous practice to
store local variables' addresses in non-local structs.
My original intention was to make sure to clear it out after it was
used, and before the function returns (which is when the address would
go stale).
However, I faced too much resistance in the Git project against such
patches, there seemed to always be the overwhelming sentiment that the
code isn't broken (even if it requires a complex and demanding analysis
to wrap one's head around _that_). Therefore, I will be pragmatic and
simply ask CodeQL to hold its peace about this issue forever.
Signed-off-by: Johannes Schindelin <[email protected]>
0 commit comments