Skip to content

Commit 9ec76ad

Browse files
pks-tgitster
authored andcommitted
Makefile: make hdr-check depend on generated headers
The "hdr-check" Makefile target compiles each of our headers as a standalone code unit to ensure that they are not missing any type declarations and can be included standalone. With the next commit we will wire up the clar unit testing framework, which will have the effect that some headers start depending on generated ones. While we could declare that dependency explicitly, it does not really feel very maintainable in the future. Instead, we do the same as in the preceding commit and have the objects depend on all of our generated headers. While again overly broad, it is easy to maintain and generating headers is not an expensive thing to do anyway. Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 11c1b5c commit 9ec76ad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3284,7 +3284,7 @@ HCC = $(HCO:hco=hcc)
32843284
@echo '#include "git-compat-util.h"' >$@
32853285
@echo '#include "$<"' >>$@
32863286

3287-
$(HCO): %.hco: %.hcc FORCE
3287+
$(HCO): %.hco: %.hcc $(GENERATED_H) FORCE
32883288
$(QUIET_HDR)$(CC) $(ALL_CFLAGS) -o /dev/null -c -xc $<
32893289

32903290
.PHONY: hdr-check $(HCO)

0 commit comments

Comments
 (0)