Skip to content

Commit a053985

Browse files
committed
fixup! Adding winget workflows
This commit changes the workflow to strip the enclosing double quotes from the PAT. In a98c3d7 (fixup! Adding winget workflows, 2024-10-28), I converted the `release-winget` workflow from hard-coding the PAT that is required as a repository secret to retrieving it from an Azure KeyVault instead. However, I made a crucial mistake there: The `az keyvault` call outputs a JSON-formatted value by default. Using the "tab-separated value" format as we do elsewhere fixes the problem: There is only one value, therefore no tab will be inserted, and certainly no double quotes will surround the retrieved value. This bug prevented the workflow from running correctly, and Matthew had to follow the steps manually instead. Let's fix this so that next time, it will work without any hassle (apart from needing to recreate the PAT and storing it in the Key Vault because of the PAT's short-lived nature). Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 69c0749 commit a053985

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/release-winget.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,5 @@ jobs:
5454
5555
# Submit manifests
5656
$manifestDirectory = Split-Path "$manifestPath"
57-
.\wingetcreate.exe submit -t "(az keyvault secret show --name ${{ secrets.WINGET_TOKEN_SECRET_NAME }} --vault-name ${{ secrets.AZURE_VAULT }} --query "value")" $manifestDirectory
57+
.\wingetcreate.exe submit -t "(az keyvault secret show --name ${{ secrets.WINGET_TOKEN_SECRET_NAME }} --vault-name ${{ secrets.AZURE_VAULT }} --query "value" --output tsv)" $manifestDirectory
5858
shell: powershell

0 commit comments

Comments
 (0)