Skip to content

Commit a45e390

Browse files
wincentgitster
authored andcommitted
gitweb: use HEAD as secondary sort key in git_get_heads_list()
The "heads" section on the gitweb summary page shows heads in `-committerdate` order (ie. the most recently-modified ones at the top), tie-breaking equal-dated refs using the implicit `refname` sort fallback. This recency-based ordering appears in multiple places in the UI, such as the project listing, the tags list, and even the shortlog and log views. Given two equal-dated refs, however, sorting the `HEAD` ref before the non-`HEAD` ref provides more useful signal than merely sorting by refname. For example, say we had "master" and "trunk" both pointing at the same commit but "trunk" was `HEAD`, sorting "trunk" first helps communicate its special status as the default branch that you'll check out if you clone the repo. Add `-HEAD` as a secondary sort key to the `git for-each-ref` call in `git_get_heads_list()` to provide the desired behavior. The most recently committed refs will appear first, but `HEAD`-ness will be used as a tie-breaker. Note that `refname` is the implicit fallback sort key, which means that two same-dated non-`HEAD` refs will continue to be sorted in lexicographical order, as they are today. Signed-off-by: Greg Hurrell <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 48bf2fa commit a45e390

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

gitweb/gitweb.perl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3779,7 +3779,8 @@ sub git_get_heads_list {
37793779
my @headslist;
37803780

37813781
open my $fd, '-|', git_cmd(), 'for-each-ref',
3782-
($limit ? '--count='.($limit+1) : ()), '--sort=-committerdate',
3782+
($limit ? '--count='.($limit+1) : ()),
3783+
'--sort=-HEAD', '--sort=-committerdate',
37833784
'--format=%(objectname) %(refname) %(subject)%00%(committer)',
37843785
@patterns
37853786
or return;

0 commit comments

Comments
 (0)