parse-options: cast long name for OPTION_ALIAS

pks-t · gitster · commit e463c5e8a0c3 · 2024-06-07T10:30:53.000-07:00
We assign the long name for OPTION_ALIAS options to a non-constant value
field. We know that the variable will never be written to, but this will
cause warnings once we enable `-Wwrite-strings`.

Cast away the constness to be prepared for this change.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/parse-options.h b/parse-options.h
@@ -355,7 +355,7 @@ struct option {
 	.type = OPTION_ALIAS, \
 	.short_name = (s), \
 	.long_name = (l), \
-	.value = (source_long_name), \
+	.value = (char *)(source_long_name), \
 }
 
 #define OPT_SUBCOMMAND_F(l, v, fn, f) { \

Original file line number	Diff line number	Diff line change
`@@ -355,7 +355,7 @@ struct option {`
`355`	`355`	`.type = OPTION_ALIAS, \`
`356`	`356`	`.short_name = (s), \`
`357`	`357`	`.long_name = (l), \`
`358`		`- .value = (source_long_name), \`
	`358`	`+ .value = (char *)(source_long_name), \`
`359`	`359`	`}`
`360`	`360`
`361`	`361`	`#define OPT_SUBCOMMAND_F(l, v, fn, f) { \`