Skip to content

status: Hydration percentage not printed when gvfs status cache is usedΒ #670

@jeffhostetler

Description

@jeffhostetler

In [1] we added code to print the GVFS hydration percentage in git status when core.virtualfilesystem is set.
GVFS users may not see this message because of the "GVFS Status Cache" feature of the "GVFS Mount Daemon".

The GVFS mount daemon periodically runs a git status --serialize in the background (after certain file system operations) and write the result to a "status-cache-file". When GVFS users run git status it silently assume --deserialize and asks the mount daemon if there is a valid cache file and simply prints the cache result on the console. The foreground status command does not scan the worktree and it does not even load the index. All it needs to do is to decode the cache file and print it.

Since the foreground status command does not load the index, it cannot compute the hydration percentage (and to make matters confusing, in the foreground status command in wt_status_get_state() and wt_status_check_sparse_checkout() the variable r->index is non-null, but the fields within it are zero. Therefore r->index->cache_nr == 0. Therefore state->sparse_checkout_percentage is set to SPARSE_CHECKOUT_DISABLED. So in wt_status_print() we DO NOT emit the Trace2 sparse-checkout/percentage. We also DO NOT print any of the messages in show_sparse_checkout_in_use().

(The background git status --serialize command will Trace2 log them (stdout is closed, so no one will see the new print messages), so we can still get telemetry, but interactive users won't see the new feature.)

[1] 78b268c...7975c98

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions