Fix BenchmarkChacha20Poly1305: arg nonceSize shadowed package var#143
Merged
Fix BenchmarkChacha20Poly1305: arg nonceSize shadowed package var#143
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical variable shadowing bug in two ChaCha20-Poly1305 benchmark functions where the parameter name nonceSize shadowed the package-level constant nonceSize = 12. This caused the switch statement logic to always match the first case, leading to panics when benchmarks were run with nonce size 24 (the X variant) because the wrong AEAD constructor was used.
Changes:
- Renamed the
nonceSizeparameter totestNonceSizeinbenchmarkChaCha20Poly1305SealandbenchmarkChaCha20Poly1305Openfunctions - Updated all usages of the parameter within these functions to use the new name
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nonceSizearg shadows packageconst nonceSize = 12, causing the switch to always hit the first case. This raises a panic (rather than skipping) because the nonce is the wrong size.