Add dev-dependencies-constants and update mocha version (#349)

Maxim Zaytsev · web-flow · commit ac3ff45121b5 · 2022-06-28T16:17:01.000+03:00
* Update versions

* Add dev-dependencies-constants

* Update task versions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -16,11 +16,11 @@ Interested in contributing to the google-play-vsts-extension project? There are
 
 **Linux**: Install [using package manager](https://nodejs.org/en/download/package-manager/)
 
-From a terminal ensure at least node 5.4.1 and npm 3:
+From a terminal ensure at least node 10.0.0 and npm 5.6.0:
 ```bash
 $ node -v && npm -v
-v6.9.1
-3.10.8
+v10.24.1
+6.14.12
 ```
 
 ## Build
diff --git a/Tasks/GooglePlayPromoteV2/task.json b/Tasks/GooglePlayPromoteV2/task.json
@@ -11,7 +11,7 @@
     ],
     "version": {
         "Major": "3",
-        "Minor": "206",
+        "Minor": "207",
         "Patch": "0"
     },
     "minimumAgentVersion": "2.182.1",
diff --git a/Tasks/GooglePlayPromoteV2/task.loc.json b/Tasks/GooglePlayPromoteV2/task.loc.json
@@ -11,7 +11,7 @@
   ],
   "version": {
     "Major": "3",
-    "Minor": "206",
+    "Minor": "207",
     "Patch": "0"
   },
   "minimumAgentVersion": "2.182.1",
diff --git a/Tasks/GooglePlayReleaseV4/task.json b/Tasks/GooglePlayReleaseV4/task.json
@@ -12,7 +12,7 @@
     "demands": [],
     "version": {
         "Major": "4",
-        "Minor": "206",
+        "Minor": "207",
         "Patch": "0"
     },
     "minimumAgentVersion": "2.182.1",
diff --git a/Tasks/GooglePlayReleaseV4/task.loc.json b/Tasks/GooglePlayReleaseV4/task.loc.json
@@ -12,7 +12,7 @@
   "demands": [],
   "version": {
     "Major": "4",
-    "Minor": "206",
+    "Minor": "207",
     "Patch": "0"
   },
   "minimumAgentVersion": "2.182.1",
diff --git a/Tasks/GooglePlayRolloutUpdateV3/task.json b/Tasks/GooglePlayRolloutUpdateV3/task.json
@@ -11,7 +11,7 @@
     ],
     "version": {
         "Major": "2",
-        "Minor": "206",
+        "Minor": "207",
         "Patch": "0"
     },
     "minimumAgentVersion": "2.182.1",
diff --git a/Tasks/GooglePlayRolloutUpdateV3/task.loc.json b/Tasks/GooglePlayRolloutUpdateV3/task.loc.json
@@ -11,7 +11,7 @@
   ],
   "version": {
     "Major": "2",
-    "Minor": "206",
+    "Minor": "207",
     "Patch": "0"
   },
   "minimumAgentVersion": "2.182.1",
diff --git a/Tasks/GooglePlayStatusUpdateV2/task.json b/Tasks/GooglePlayStatusUpdateV2/task.json
@@ -11,7 +11,7 @@
     ],
     "version": {
         "Major": "2",
-        "Minor": "206",
+        "Minor": "207",
         "Patch": "0"
     },
     "minimumAgentVersion": "2.182.1",
diff --git a/Tasks/GooglePlayStatusUpdateV2/task.loc.json b/Tasks/GooglePlayStatusUpdateV2/task.loc.json
@@ -11,7 +11,7 @@
   ],
   "version": {
     "Major": "2",
-    "Minor": "206",
+    "Minor": "207",
     "Patch": "0"
   },
   "minimumAgentVersion": "2.182.1",
diff --git a/dev-dependencies-constants.js b/dev-dependencies-constants.js
@@ -0,0 +1,15 @@
+/**
+ *  Common dev dependencies constants
+ *  @module  dev-dependencies-constants
+*/
+
+/** Target mocha version for running tests */
+exports.MOCHA_TARGET_VERSION = '6.2.3';
+/** Minimum supported typescript version */
+exports.TSC_MIN_VERSION = '3.6.3';
+/** Current typescript version */
+exports.TSC_CURRENT_VERSION = '4.0.2';
+/** Minimum supported node version */
+exports.NODE_MIN_VERSION = '10.0.0';
+/** Minimum supported npm version */
+exports.NPM_MIN_VERSION = '5.6.0';
diff --git a/make-util.js b/make-util.js
@@ -17,7 +17,13 @@ var makeOptions = require('./make-options.json');
 // list of .NET culture names
 var cultureNames = [ 'cs', 'de', 'es', 'fr', 'it', 'ja', 'ko', 'pl', 'pt-BR', 'ru', 'tr', 'zh-Hans', 'zh-Hant' ];
 
-const allowedTypescriptVersions = ['2.3.4', '4.0.2'];
+// core dev-dependencies constants
+const constants = require('./dev-dependencies-constants');
+
+const TSC_MIN_VERSION = constants.TSC_MIN_VERSION;
+const TSC_CURRENT_VERSION = constants.TSC_CURRENT_VERSION;
+
+const allowedTypescriptVersions = [TSC_MIN_VERSION, TSC_CURRENT_VERSION];
 
 //------------------------------------------------------------------------------
 // shell functions
diff --git a/make.js b/make.js
@@ -62,10 +62,16 @@ var packagePath = path.join(__dirname, '_package');
 var testTasksPath = path.join(__dirname, '_test', 'Tasks');
 var testPath = path.join(__dirname, '_test', 'Tests');
 
-// node min version
-var minNodeVer = '4.0.0';
-if (semver.lt(process.versions.node, minNodeVer)) {
-    fail('requires node >= ' + minNodeVer + '.  installed: ' + process.versions.node);
+// core dev-dependencies constants
+const constants = require('./dev-dependencies-constants');
+
+const MOCHA_TARGET_VERSION = constants.MOCHA_TARGET_VERSION;
+const TSC_MIN_VERSION = constants.TSC_MIN_VERSION;
+const NODE_MIN_VERSION = constants.NODE_MIN_VERSION;
+const NPM_MIN_VERSION = constants.NPM_MIN_VERSION;
+
+if (semver.lt(process.versions.node,  NODE_MIN_VERSION)) {
+    fail(`requires node >= ${NODE_MIN_VERSION}. installed: ${process.versions.node}`);
 }
 
 // Node 14 is supported by the build system, but not currently by the agent. Block it for now
@@ -108,10 +114,10 @@ target.clean = function () {
 target.build = function() {
     target.clean();
 
-    ensureTool('tsc', '--version', 'Version 3.6.3');
+    ensureTool('tsc', '--version', `Version ${TSC_MIN_VERSION}`);
     ensureTool('npm', '--version', function (output) {
-        if (semver.lt(output, '3.10.8')) {
-            fail('expected 3.10.8 or higher');
+        if (semver.lt(output, NPM_MIN_VERSION)) {
+            fail(`expected ${NPM_MIN_VERSION} or higher`);
         }
     });
 
@@ -248,8 +254,8 @@ target.build = function() {
 // node make.js test --task ShellScript --suite L0
 //
 target.test = function() {
-    ensureTool('tsc', '--version', 'Version 3.6.3');
-    ensureTool('mocha', '--version', '9.2.2');
+    ensureTool('tsc', '--version', `Version ${TSC_MIN_VERSION}`);
+    ensureTool('mocha', '--version', MOCHA_TARGET_VERSION);
 
     // run the tests
     var suiteType = options.suite || 'L0';
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
diff --git a/vsts-extension-google-play.json b/vsts-extension-google-play.json
