Skip to content

Commit 255d86e

Browse files
committed
revert copilot changes
1 parent 5e84934 commit 255d86e

File tree

4 files changed

+11
-40
lines changed

4 files changed

+11
-40
lines changed

docs/examples_notebooks/index_migration_to_v1.ipynb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,10 @@
202202
"metadata": {},
203203
"outputs": [],
204204
"source": [
205-
"from graphrag.index.flows.generate_text_embeddings import generate_text_embeddings\n",
206-
"\n",
207205
"from graphrag.cache.factory import CacheFactory\n",
208206
"from graphrag.callbacks.noop_workflow_callbacks import NoopWorkflowCallbacks\n",
209207
"from graphrag.config.embeddings import get_embedded_fields, get_embedding_settings\n",
208+
"from graphrag.index.flows.generate_text_embeddings import generate_text_embeddings\n",
210209
"\n",
211210
"# We only need to re-run the embeddings workflow, to ensure that embeddings for all required search fields are in place\n",
212211
"# We'll construct the context and run this function flow directly to avoid everything else\n",

examples_notebooks/community_contrib/yfiles-jupyter-graphs/graph-visualization.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@
2929
"\n",
3030
"import pandas as pd\n",
3131
"import tiktoken\n",
32-
"from graphrag.query.llm.oai.chat_openai import ChatOpenAI\n",
33-
"from graphrag.query.llm.oai.embedding import OpenAIEmbedding\n",
34-
"from graphrag.query.llm.oai.typing import OpenaiApiType\n",
3532
"\n",
3633
"from graphrag.query.context_builder.entity_extraction import EntityVectorStoreKey\n",
3734
"from graphrag.query.indexer_adapters import (\n",
@@ -41,6 +38,9 @@
4138
" read_indexer_reports,\n",
4239
" read_indexer_text_units,\n",
4340
")\n",
41+
"from graphrag.query.llm.oai.chat_openai import ChatOpenAI\n",
42+
"from graphrag.query.llm.oai.embedding import OpenAIEmbedding\n",
43+
"from graphrag.query.llm.oai.typing import OpenaiApiType\n",
4444
"from graphrag.query.structured_search.local_search.mixed_context import (\n",
4545
" LocalSearchMixedContext,\n",
4646
")\n",

graphrag/storage/factory.py

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ def register(
4444
------
4545
TypeError: If creator is a class type instead of a factory function.
4646
"""
47-
if isinstance(creator, type):
48-
msg = "Registering classes directly is no longer supported. Please provide a factory function instead."
49-
raise TypeError(msg)
5047
cls._registry[storage_type] = creator
5148

5249
@classmethod
@@ -91,24 +88,7 @@ def is_supported_type(cls, storage_type: str) -> bool:
9188

9289

9390
# --- register built-in storage implementations ---
94-
StorageFactory.register(
95-
StorageType.blob.value,
96-
lambda **kwargs: BlobPipelineStorage(**{
97-
k: v for k, v in kwargs.items() if k != "type"
98-
}),
99-
)
100-
StorageFactory.register(
101-
StorageType.cosmosdb.value,
102-
lambda **kwargs: CosmosDBPipelineStorage(**{
103-
k: v for k, v in kwargs.items() if k != "type"
104-
}),
105-
)
106-
StorageFactory.register(
107-
StorageType.file.value,
108-
lambda **kwargs: FilePipelineStorage(**{
109-
k: v for k, v in kwargs.items() if k != "type"
110-
}),
111-
)
112-
StorageFactory.register(
113-
StorageType.memory.value, lambda **_kwargs: MemoryPipelineStorage()
114-
)
91+
StorageFactory.register(StorageType.blob.value, BlobPipelineStorage)
92+
StorageFactory.register(StorageType.cosmosdb.value, CosmosDBPipelineStorage)
93+
StorageFactory.register(StorageType.file.value, FilePipelineStorage)
94+
StorageFactory.register(StorageType.memory.value, MemoryPipelineStorage)

graphrag/vector_stores/factory.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ def register(
5151
------
5252
TypeError: If creator is a class type instead of a factory function.
5353
"""
54-
if isinstance(creator, type):
55-
msg = "Registering classes directly is no longer supported. Please provide a factory function instead."
56-
raise TypeError(msg)
5754
cls._registry[vector_store_type] = creator
5855

5956
@classmethod
@@ -98,13 +95,8 @@ def is_supported_type(cls, vector_store_type: str) -> bool:
9895

9996

10097
# --- register built-in vector store implementations ---
98+
VectorStoreFactory.register(VectorStoreType.LanceDB.value, LanceDBVectorStore)
10199
VectorStoreFactory.register(
102-
VectorStoreType.LanceDB.value, lambda **kwargs: LanceDBVectorStore(**kwargs)
103-
)
104-
VectorStoreFactory.register(
105-
VectorStoreType.AzureAISearch.value,
106-
lambda **kwargs: AzureAISearchVectorStore(**kwargs),
107-
)
108-
VectorStoreFactory.register(
109-
VectorStoreType.CosmosDB.value, lambda **kwargs: CosmosDBVectorStore(**kwargs)
100+
VectorStoreType.AzureAISearch.value, AzureAISearchVectorStore
110101
)
102+
VectorStoreFactory.register(VectorStoreType.CosmosDB.value, CosmosDBVectorStore)

0 commit comments

Comments
 (0)