Store extraction error for LazyImageLayers (#2429)

* Store extraction error for `LazyImageLayers`

Have `test\internal\layers.LazyImageLayers` always fail if image
extraction fails initially.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>

* Build required binaries

Add build stages for various binaries to ensure they compile without
issue.
Alphabetize build steps to make lookup easier.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>

---------

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>

Author: helsaawy

.github/workflows/ci.yml

@@ -632,20 +632,30 @@ jobs:
 
       - run: ${{ env.GO_BUILD_CMD }} ./cmd/containerd-shim-runhcs-v1
         name: Build containerd-shim-runhcs-v1.exe
+      - run: ${{ env.GO_BUILD_CMD }} ./cmd/device-util
+        name: Build device-util.exe
+      - run: ${{ env.GO_BUILD_CMD }} ./cmd/jobobject-util
+        name: Build jobobject-util.exe
+      - run: ${{ env.GO_BUILD_CMD }} ./cmd/mkuvmcim
+        name: Build mkuvmcim.exe
+      - run: ${{ env.GO_BUILD_CMD }} ./cmd/ncproxy
+        name: Build ncproxy.exe
       - run: ${{ env.GO_BUILD_CMD }} ./cmd/runhcs
         name: Build runhcs.exe
+      - run: ${{ env.GO_BUILD_CMD }} ./cmd/shimdiag
+        name: Build shimdiag.exe
       - run: ${{ env.GO_BUILD_CMD }} ./cmd/tar2ext4
         name: Build tar2ext4.exe
       - run: ${{ env.GO_BUILD_CMD }} ./cmd/wclayer
         name: Build wclayer.exe
-      - run: ${{ env.GO_BUILD_CMD }} ./cmd/device-util
-        name: Build device-util.exe
-      - run: ${{ env.GO_BUILD_CMD }} ./cmd/ncproxy
-        name: Build ncproxy.exe
       - run: ${{ env.GO_BUILD_CMD }} ./internal/tools/grantvmgroupaccess
         name: Build grantvmgroupaccess.exe
+      - run: ${{ env.GO_BUILD_CMD }} ./internal/tools/hvsocketaddr
+        name: Build hvsocketaddr.exe
       - run: ${{ env.GO_BUILD_CMD }} ./internal/tools/networkagent
         name: Build networkagent.exe
+      - run: ${{ env.GO_BUILD_CMD }} ./internal/tools/rootfs
+        name: Build rootfs.exe
       - run: ${{ env.GO_BUILD_CMD }} ./internal/tools/securitypolicy
         name: Build securitypolicy.exe
       - run: ${{ env.GO_BUILD_CMD }} ./internal/tools/securitypolicy
@@ -657,8 +667,6 @@ jobs:
         name: Build uvmboot.exe
       - run: ${{ env.GO_BUILD_CMD }} ./internal/tools/zapdir
         name: Build zapdir.exe
-      - run: ${{ env.GO_BUILD_CMD }} ./internal/tools/hvsocketaddr
-        name: Build hvsocketaddr.exe
 
       - uses: actions/upload-artifact@v4
         if: ${{ github.event_name == 'pull_request' }}

internal/safefile/safeopen.go

@@ -18,6 +18,8 @@ import (
 	winio "github.com/Microsoft/go-winio"
 )
 
+// TODO(go1.24): use [os.Root] and co. here
+
 func OpenRoot(path string) (*os.File, error) {
 	longpath, err := longpath.LongAbs(path)
 	if err != nil {

test/internal/layers/lazy.go

@@ -42,9 +42,11 @@ type LazyImageLayers struct {
 	// Defaults to [os.TempDir] if left empty.
 	TempPath string
 	// dedicated directory, under [TempPath], to store layers in
-	dir    string
-	once   sync.Once
-	layers []string // extracted layer directories, under [dir]
+	dir string
+
+	once       sync.Once // sets the [layers] and [extractErr] fields
+	layers     []string  // extracted layer directories, under [dir]
+	extractErr error     // extraction error
 }
 
 type extractHandler func(ctx context.Context, rc io.ReadCloser, dir string, parents []string) error
@@ -62,7 +64,10 @@ func (x *LazyImageLayers) Close(ctx context.Context) error {
 		"image": x.Image,
 	}).Debug("removing image")
 
-	if _, err := os.Stat(x.dir); err != nil && !os.IsNotExist(err) {
+	if _, err := os.Stat(x.dir); err != nil {
+		if os.IsNotExist(err) {
+			return nil
+		}
 		return fmt.Errorf("path %q is not valid: %w", x.dir, err)
 	}
 
@@ -83,13 +88,12 @@ func (x *LazyImageLayers) Layers(ctx context.Context, tb testing.TB) []string {
 		return nil
 	}
 
-	var err error
 	x.once.Do(func() {
-		err = x.extractLayers(ctx)
+		x.extractErr = x.extractLayers(ctx)
 	})
-	if err != nil {
+	if x.extractErr != nil {
 		x.Close(ctx)
-		tb.Fatal(err)
+		tb.Fatal(x.extractErr)
 	}
 	return x.layers
 }