Skip to content

Commit 63c600d

Browse files
authored
Merge pull request #2562 from anmaxvl/backport-kill-fix
[ms/release/0.1] backport signal init process fix
2 parents e4ce1ac + 5d9dd0a commit 63c600d

File tree

2 files changed

+1
-14
lines changed

2 files changed

+1
-14
lines changed

internal/guest/runtime/hcsv2/uvm.go

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -684,17 +684,7 @@ func (h *Host) SignalContainerProcess(ctx context.Context, containerID string, p
684684
return err
685685
}
686686

687-
signalingInitProcess := (processID == c.initProcess.pid)
688-
689-
// Don't allow signalProcessV2 to route around container shutdown policy
690-
// Sending SIGTERM or SIGKILL to a containers init process will shut down
691-
// the container.
692-
if signalingInitProcess {
693-
if (signal == unix.SIGTERM) || (signal == unix.SIGKILL) {
694-
graceful := (signal == unix.SIGTERM)
695-
return h.ShutdownContainer(ctx, containerID, graceful)
696-
}
697-
}
687+
signalingInitProcess := processID == c.initProcess.pid
698688

699689
startupArgList := p.(*containerProcess).spec.Args
700690
err = h.securityPolicyEnforcer.EnforceSignalContainerProcessPolicy(ctx, containerID, signal, signalingInitProcess, startupArgList)

internal/guest/runtime/runc/container.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,6 @@ func (c *container) ExecProcess(process *oci.Process, stdioSet *stdio.Connection
7878
func (c *container) Kill(signal syscall.Signal) error {
7979
logrus.WithField(logfields.ContainerID, c.id).Debug("runc::container::Kill")
8080
args := []string{"kill"}
81-
if signal == syscall.SIGTERM || signal == syscall.SIGKILL {
82-
args = append(args, "--all")
83-
}
8481
args = append(args, c.id, strconv.Itoa(int(signal)))
8582
cmd := runcCommand(args...)
8683
out, err := cmd.CombinedOutput()

0 commit comments

Comments
 (0)