Skip to content

Commit 69ebd30

Browse files
MahatiCambarve
authored andcommitted
CWCOW: Fix rebase conflict
Signed-off-by: Mahati Chamarthy <[email protected]>
1 parent 1b2350e commit 69ebd30

File tree

2 files changed

+4
-26
lines changed

2 files changed

+4
-26
lines changed

pkg/securitypolicy/regopolicy_linux_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5963,7 +5963,7 @@ func Test_Rego_GetUserInfo_WithEtcPasswdAndGroup(t *testing.T) {
59635963
t.Fatalf("Failed to write /etc/group: %v", err)
59645964
}
59655965

5966-
regoEnforcer, err := newRegoPolicy(openDoorRego, []oci.Mount{}, []oci.Mount{})
5966+
regoEnforcer, err := newRegoPolicy(openDoorRego, []oci.Mount{}, []oci.Mount{}, testOSType)
59675967
if err != nil {
59685968
t.Errorf("cannot compile open door rego policy: %v", err)
59695969
return
@@ -6116,7 +6116,7 @@ func Test_Rego_GetUserInfo_WithEtcPasswdAndGroup(t *testing.T) {
61166116
func Test_Rego_GetUserInfo_NoEtc(t *testing.T) {
61176117
testDir := t.TempDir()
61186118

6119-
regoEnforcer, err := newRegoPolicy(openDoorRego, []oci.Mount{}, []oci.Mount{})
6119+
regoEnforcer, err := newRegoPolicy(openDoorRego, []oci.Mount{}, []oci.Mount{}, testOSType)
61206120
if err != nil {
61216121
t.Errorf("cannot compile open door rego policy: %v", err)
61226122
return
@@ -6197,7 +6197,7 @@ func Test_Rego_GetUserInfo_EtcPasswdOnly(t *testing.T) {
61976197
t.Fatalf("Failed to write /etc/passwd: %v", err)
61986198
}
61996199

6200-
regoEnforcer, err := newRegoPolicy(openDoorRego, []oci.Mount{}, []oci.Mount{})
6200+
regoEnforcer, err := newRegoPolicy(openDoorRego, []oci.Mount{}, []oci.Mount{}, testOSType)
62016201
if err != nil {
62026202
t.Errorf("cannot compile open door rego policy: %v", err)
62036203
return

pkg/securitypolicy/securitypolicy_linux.go

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -40,28 +40,7 @@ func HugePagesMountsDir(sandboxID string) string {
4040
return specInternal.HugePagesMountsDir(sandboxID)
4141
}
4242

43-
func getUser(passwdPath string, filter func(user.User) bool) (user.User, error) {
44-
users, err := user.ParsePasswdFileFilter(passwdPath, filter)
45-
if err != nil {
46-
return user.User{}, err
47-
}
48-
if len(users) != 1 {
49-
return user.User{}, errors.Errorf("expected exactly 1 user matched '%d'", len(users))
50-
}
51-
return users[0], nil
52-
}
53-
54-
func getGroup(groupPath string, filter func(user.Group) bool) (user.Group, error) {
55-
groups, err := user.ParseGroupFileFilter(groupPath, filter)
56-
if err != nil {
57-
return user.Group{}, err
58-
}
59-
if len(groups) != 1 {
60-
return user.Group{}, errors.Errorf("expected exactly 1 group matched '%d'", len(groups))
61-
}
62-
return groups[0], nil
63-
}
64-
func (policy *regoEnforcer) GetAllUserInfo(process *oci.Process, rootPath string) (
43+
func GetAllUserInfo(process *oci.Process, rootPath string) (
6544
userIDName IDName,
6645
groupIDNames []IDName,
6746
umask string,
@@ -130,7 +109,6 @@ func (policy *regoEnforcer) GetAllUserInfo(process *oci.Process, rootPath string
130109
groupIDName.Name = groupInfo.Name
131110
} else {
132111
checkGroup = false
133-
err = nil
134112
}
135113

136114
groupIDNames = []IDName{groupIDName}

0 commit comments

Comments
 (0)