You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR addresses writing-style convention violations across the
hve-core documentation. It systematically remediates three violation
patterns (em dashes, bolded-prefix list items, and pseudo-headings)
across 52 files while adding markdownlint rules that prevent future
regressions. All changes are documentation and configuration only; no
functional code was modified.
## Changes
### Linting Infrastructure
Two new **custom markdownlint rules** were added via
`markdownlint-rule-search-replace` (v1.2.0) to catch future
writing-style violations at lint time.
- Added `no-em-dash` rule to *`.markdownlint.json`* detecting U+2014 em
dash characters in prose
- Added `no-bolded-prefix-list` rule to *`.markdownlint.json`* detecting
`**Term:** description` patterns in list items
- Both rules include `information` URLs pointing back to
*writing-style.instructions.md* for contributor guidance
- Registered the search-replace plugin in *`.markdownlint-cli2.jsonc`*
- Changed `MD024.siblings_only` from `false` to `true` to accommodate
new headings introduced by pseudo-heading conversions
- Added `markdownlint-rule-search-replace` as a dev dependency in
*package.json*
### Em Dash Remediation
Replaced 41 em dash instances across documentation with
context-appropriate punctuation following the writing-style convention.
- Substituted colons where the em dash introduced an explanation or
elaboration
- Substituted parentheses where the em dash framed a parenthetical aside
- Applied across contributing guides, architecture docs, RPI workflow
documentation, extension templates, getting-started guides, and
customization content
### Bolded-Prefix and Pseudo-Heading Conversions
Converted 370+ instances of bolded-prefix list items and pseudo-headings
into convention-compliant formatting using three remediation strategies
matched to content type.
- Converted bolded text used as section headers into proper markdown
headings (`###`, `####`, `#####`) based on document hierarchy
- Replaced `**Term:** description` patterns with plain `Term:
description` for inline definitions
- Restructured metadata-style lists into definition tables where the
content warranted tabular presentation
- Added an inline `<!-- markdownlint-disable-next-line search-replace
-->` comment in *writing-style.instructions.md* to suppress a
false-positive lint hit on the instructional em dash example
### Documentation Updates
Applied writing-style fixes across all major documentation areas.
- *docs/architecture/*: Heading conversions and em dash replacements in
workflow and testing docs
- *docs/contributing/*: Bolded-prefix remediation across instructions,
prompts, agents, and release process guides
- *docs/getting-started/*: Consistent fixes across all six installation
method guides
- *docs/rpi/*: Pseudo-heading conversions in researcher, planner, and
implementor docs
- *docs/security/*: Heading and list-item formatting in security
planning documentation
- *docs/customization/* and *docs/design-thinking/*: Em dash and
bolded-prefix fixes
- *scripts/*: README heading conversions across extension, lib, linting,
security, and tests directories
- *extension/*: Pseudo-heading fixes in *PACKAGING.md* and em dash
replacement in *README.template.md*
- *.devcontainer/README.md* and *SUPPORT.md*: Writing-style compliance
fixes
## Related Issues
Closes#504
## Notes
- The 662 remaining lint violations (158 em dash + 504 bolded-prefix)
are in out-of-scope files (instructions, agents, prompts, skills) and
represent the expected baseline documented in Issue #504
- Content meaning and structure are preserved through all conversions;
only formatting changed
Co-authored-by: Bill Berry <wbery@microsoft.com>
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+9-9Lines changed: 9 additions & 9 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -33,11 +33,11 @@ Select all that apply:
33
33
*[ ] Copilot agent (`.github/agents/*.agent.md`)
34
34
*[ ] Copilot skill (`.github/skills/*/SKILL.md`)
35
35
36
-
> **Note for AI Artifact Contributors**:
36
+
> Note for AI Artifact Contributors:
37
37
>
38
-
> ***Agents**: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review `.github/agents/` before creating new ones.
39
-
> ***Skills**: Must include both bash and PowerShell scripts. See [Skills](../docs/contributing/skills.md).
40
-
> ***Model Versions**: Only contributions targeting the **latest Anthropic and OpenAI models** will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
38
+
> * Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review `.github/agents/` before creating new ones.
39
+
> * Skills: Must include both bash and PowerShell scripts. See [Skills](../docs/contributing/skills.md).
40
+
> * Model Versions: Only contributions targeting the **latest Anthropic and OpenAI models** will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
41
41
> * See [Agents Not Accepted](../docs/contributing/custom-agents.md#agents-not-accepted) and [Model Version Requirements](../docs/contributing/ai-artifacts-common.md#model-version-requirements).
42
42
43
43
**Other:**
@@ -64,11 +64,11 @@ Select all that apply:
64
64
65
65
For detailed contribution requirements, see:
66
66
67
-
***Common Standards**: [docs/contributing/ai-artifacts-common.md](../docs/contributing/ai-artifacts-common.md) - Shared standards for XML blocks, markdown quality, RFC 2119, validation, and testing
68
-
***Agents**: [docs/contributing/custom-agents.md](../docs/contributing/custom-agents.md) - Agent configurations with tools and behavior patterns
69
-
***Prompts**: [docs/contributing/prompts.md](../docs/contributing/prompts.md) - Workflow-specific guidance with template variables
70
-
***Instructions**: [docs/contributing/instructions.md](../docs/contributing/instructions.md) - Technology-specific standards with glob patterns
71
-
***Skills**: [docs/contributing/skills.md](../docs/contributing/skills.md) - Task execution utilities with cross-platform scripts
67
+
* Common Standards: [docs/contributing/ai-artifacts-common.md](../docs/contributing/ai-artifacts-common.md) - Shared standards for XML blocks, markdown quality, RFC 2119, validation, and testing
68
+
* Agents: [docs/contributing/custom-agents.md](../docs/contributing/custom-agents.md) - Agent configurations with tools and behavior patterns
69
+
* Prompts: [docs/contributing/prompts.md](../docs/contributing/prompts.md) - Workflow-specific guidance with template variables
70
+
* Instructions: [docs/contributing/instructions.md](../docs/contributing/instructions.md) - Technology-specific standards with glob patterns
71
+
* Skills: [docs/contributing/skills.md](../docs/contributing/skills.md) - Task execution utilities with cross-platform scripts
* Integration: Results published to OpenSSF Scorecard API and GitHub Security tab
225
+
* Badge: Live Scorecard badge available for README display
226
+
* Artifacts: SARIF results retained for 90 days
227
227
228
-
**Outputs**: SARIF results uploaded to GitHub Security tab, job summary with badge link
228
+
Outputs: SARIF results uploaded to GitHub Security tab, job summary with badge link
229
229
230
230
## Architecture Decisions
231
231
@@ -235,9 +235,9 @@ The SHA staleness check workflow complements Dependabot by monitoring for stale
235
235
236
236
**Current Architecture:** CodeQL now runs exclusively through orchestrator workflows to prevent duplicate runs and ensure consistent security scanning:
237
237
238
-
* **CodeQL PR validation**: Runs via `pr-validation.yml` on all PR activity (open, push, reopen)
239
-
* **Main branch**: Runs via `release-stable.yml` on every push to main
240
-
* **Weekly scan**: Standalone scheduled run every Sunday at 4 AM UTC for continuous security monitoring
238
+
* CodeQL PR validation: Runs via `pr-validation.yml` on all PR activity (open, push, reopen)
239
+
* Main branch: Runs via `release-stable.yml` on every push to main
240
+
* Weekly scan: Standalone scheduled run every Sunday at 4 AM UTC for continuous security monitoring
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -357,10 +357,10 @@ This project uses [release-please](https://github.com/googleapis/release-please)
357
357
358
358
### How Releases Work
359
359
360
-
1.**Commit with Conventional Commits** - All commits to `main` must follow conventional commit format (see [commit message instructions](./.github/instructions/hve-core/commit-message.instructions.md))
361
-
2.**Release PR Creation** - After commits are pushed to `main`, release-please automatically creates or updates a "release PR"
362
-
3.**Review Release PR** - Maintainers review the release PR to verify version bump and changelog accuracy
363
-
4.**Merge to Release** - When the release PR is merged, a git tag and GitHub Release are automatically created
360
+
1. Commit with Conventional Commits - All commits to `main` must follow conventional commit format (see [commit message instructions](./.github/instructions/hve-core/commit-message.instructions.md))
361
+
2. Release PR Creation - After commits are pushed to `main`, release-please automatically creates or updates a "release PR"
362
+
3. Review Release PR - Maintainers review the release PR to verify version bump and changelog accuracy
363
+
4. Merge to Release - When the release PR is merged, a git tag and GitHub Release are automatically created
0 commit comments