fix: empty suggestions block history scrolling (#347)

cpendery · web-flow · commit 19fc2846dc3d · 2025-07-20T10:24:45.000-07:00
* fix: empty suggestions block history scrolling

Signed-off-by: Chapman Pendery &lt;cpendery@vt.edu&gt;

* fix: snapshot

Signed-off-by: Chapman Pendery &lt;cpendery@vt.edu&gt;

---------

Signed-off-by: Chapman Pendery &lt;cpendery@vt.edu&gt;
diff --git a/src/runtime/runtime.ts b/src/runtime/runtime.ts
@@ -112,6 +112,7 @@ export const getSuggestions = async (cmd: string, cwd: string, shell: Shell): Pr
   }
   const result = await runSubcommand(activeCmd.slice(1), subcommand, resolvedCwd, shell);
   if (result == null) return;
+  if (result.suggestions.length == 0 && !result.argumentDescription) return;
 
   const charactersToDrop = lastCommand?.complete ? 0 : lastCommand?.tokenLength;
   return { ...result, charactersToDrop };
diff --git a/src/tests/runtime/__snapshots__/runtime.test.ts.snap b/src/tests/runtime/__snapshots__/runtime.test.ts.snap
@@ -293,12 +293,7 @@ exports[`parseCommand completedOptionWithArg 1`] = `
 }
 `;
 
-exports[`parseCommand emptySuggestions 1`] = `
-{
-  "charactersToDrop": 2,
-  "suggestions": [],
-}
-`;
+exports[`parseCommand emptySuggestions 1`] = `undefined`;
 
 exports[`parseCommand exclusiveOnOption 1`] = `
 {
@@ -528,12 +523,7 @@ exports[`parseCommand noArgsArgumentGiven 1`] = `
 }
 `;
 
-exports[`parseCommand noOptionsSuggestedDuringVariadicArg 1`] = `
-{
-  "charactersToDrop": 3,
-  "suggestions": [],
-}
-`;
+exports[`parseCommand noOptionsSuggestedDuringVariadicArg 1`] = `undefined`;
 
 exports[`parseCommand optionsSuggestedAfterVariadicArg 1`] = `
 {

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ export const getSuggestions = async (cmd: string, cwd: string, shell: Shell): Pr`
`112`	`112`	`}`
`113`	`113`	`const result = await runSubcommand(activeCmd.slice(1), subcommand, resolvedCwd, shell);`
`114`	`114`	`if (result == null) return;`
	`115`	`+ if (result.suggestions.length == 0 && !result.argumentDescription) return;`
`115`	`116`
`116`	`117`	`const charactersToDrop = lastCommand?.complete ? 0 : lastCommand?.tokenLength;`
`117`	`118`	`return { ...result, charactersToDrop };`
Original file line number	Diff line number	Diff line change
@@ -293,12 +293,7 @@ exports[`parseCommand completedOptionWithArg 1`] = `
`293`	`293`	`}`
`294`	`294`	`;
`295`	`295`
`296`		-exports[`parseCommand emptySuggestions 1`] = `
`297`		`-{`
`298`		`- "charactersToDrop": 2,`
`299`		`- "suggestions": [],`
`300`		`-}`
`301`		-`;
	`296`	+exports[`parseCommand emptySuggestions 1`] = `undefined`;
`302`	`297`
`303`	`298`	exports[`parseCommand exclusiveOnOption 1`] = `
`304`	`299`	`{`
@@ -528,12 +523,7 @@ exports[`parseCommand noArgsArgumentGiven 1`] = `
`528`	`523`	`}`
`529`	`524`	`;
`530`	`525`
`531`		-exports[`parseCommand noOptionsSuggestedDuringVariadicArg 1`] = `
`532`		`-{`
`533`		`- "charactersToDrop": 3,`
`534`		`- "suggestions": [],`
`535`		`-}`
`536`		-`;
	`526`	+exports[`parseCommand noOptionsSuggestedDuringVariadicArg 1`] = `undefined`;
`537`	`527`
`538`	`528`	exports[`parseCommand optionsSuggestedAfterVariadicArg 1`] = `
`539`	`529`	`{`