Skip to content

Commit 19b5dcf

Browse files
authored
Fix attach connector in java 10 error: cannot attach in java 10 (#187)
1 parent 45bc72a commit 19b5dcf

File tree

1 file changed

+8
-0
lines changed
  • com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core

1 file changed

+8
-0
lines changed

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugUtility.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,14 @@ public static IDebugSession attach(VirtualMachineManager vmManager, String hostN
194194
throws IOException, IllegalConnectorArgumentsException {
195195
List<AttachingConnector> connectors = vmManager.attachingConnectors();
196196
AttachingConnector connector = connectors.get(0);
197+
// in JDK 10, the first AttachingConnector is not the one we want
198+
final String SUN_ATTACH_CONNECTOR = "com.sun.tools.jdi.SocketAttachingConnector";
199+
for (AttachingConnector con : connectors) {
200+
if (con.getClass().getName().equals(SUN_ATTACH_CONNECTOR)) {
201+
connector = con;
202+
break;
203+
}
204+
}
197205
Map<String, Argument> arguments = connector.defaultArguments();
198206
arguments.get(HOSTNAME).setValue(hostName);
199207
arguments.get(PORT).setValue(String.valueOf(port));

0 commit comments

Comments
 (0)