Disable unnecessary request handlers for noDebug mode. (#204)

* Disable unnecessary request handlers for noDebug mode.

* Better naming.

* Repleace boolean with a 2-element enum LaunchMode

* Update LaunchMode.java

Author: Eskibear

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/DebugAdapter.java

@@ -48,14 +48,16 @@ public class DebugAdapter implements IDebugAdapter {
     private static final Logger logger = Logger.getLogger(Configuration.LOGGER_NAME);
 
     private IDebugAdapterContext debugContext = null;
-    private Map<Command, List<IDebugRequestHandler>> requestHandlers = null;
+    private Map<Command, List<IDebugRequestHandler>> requestHandlersForDebug = null;
+    private Map<Command, List<IDebugRequestHandler>> requestHandlersForNoDebug = null;
 
     /**
      * Constructor.
      */
     public DebugAdapter(IProtocolServer server, IProviderContext providerContext) {
         this.debugContext = new DebugAdapterContext(server, providerContext);
-        requestHandlers = new HashMap<>();
+        requestHandlersForDebug = new HashMap<>();
+        requestHandlersForNoDebug = new HashMap<>();
         initialize();
     }
 
@@ -73,7 +75,8 @@ public CompletableFuture<Messages.Response> dispatchRequest(Messages.Request req
             // the operation is meaningless
             return CompletableFuture.completedFuture(response);
         }
-        List<IDebugRequestHandler> handlers = requestHandlers.get(command);
+        List<IDebugRequestHandler> handlers = this.debugContext.getLaunchMode() == LaunchMode.DEBUG
+                ? requestHandlersForDebug.get(command) : requestHandlersForNoDebug.get(command);
         if (handlers != null && !handlers.isEmpty()) {
             CompletableFuture<Messages.Response> future = CompletableFuture.completedFuture(response);
             for (IDebugRequestHandler handler : handlers) {
@@ -92,11 +95,11 @@ public CompletableFuture<Messages.Response> dispatchRequest(Messages.Request req
     private void initialize() {
         // Register request handlers.
         // When there are multiple handlers registered for the same request, follow the rule "first register, first execute".
-        registerHandler(new InitializeRequestHandler());
-        registerHandler(new LaunchRequestHandler());
+        registerHandler(new InitializeRequestHandler(), true, true);
+        registerHandler(new LaunchRequestHandler(), true, true);
         registerHandler(new AttachRequestHandler());
-        registerHandler(new ConfigurationDoneRequestHandler());
-        registerHandler(new DisconnectRequestHandler());
+        registerHandler(new ConfigurationDoneRequestHandler(), true, true);
+        registerHandler(new DisconnectRequestHandler(), true, true);
         registerHandler(new SetBreakpointsRequestHandler());
         registerHandler(new SetExceptionBreakpointsRequestHandler());
         registerHandler(new SourceRequestHandler());
@@ -113,6 +116,19 @@ private void initialize() {
     }
 
     private void registerHandler(IDebugRequestHandler handler) {
+        registerHandler(handler, true, false);
+    }
+
+    private void registerHandler(IDebugRequestHandler handler, boolean forDebug, boolean forNoDebug) {
+        if (forDebug) {
+            registerHandler(requestHandlersForDebug, handler);
+        }
+        if (forNoDebug) {
+            registerHandler(requestHandlersForNoDebug, handler);
+        }
+    }
+
+    private void registerHandler(Map<Command, List<IDebugRequestHandler>> requestHandlers, IDebugRequestHandler handler) {
         for (Command command : handler.getTargetCommands()) {
             List<IDebugRequestHandler> handlerList = requestHandlers.get(command);
             if (handlerList == null) {

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/DebugAdapterContext.java

@@ -38,6 +38,7 @@ public class DebugAdapterContext implements IDebugAdapterContext {
     private Charset debuggeeEncoding;
     private transient boolean vmTerminated;
     private boolean isVmStopOnEntry = false;
+    private LaunchMode launchMode = LaunchMode.DEBUG;
     private String mainClass;
     private StepFilters stepFilters;
 
@@ -231,4 +232,14 @@ public StepFilters getStepFilters() {
     public IStackFrameManager getStackFrameManager() {
         return stackFrameManager;
     }
+
+    @Override
+    public LaunchMode getLaunchMode() {
+        return launchMode;
+    }
+
+    @Override
+    public void setLaunchMode(LaunchMode launchMode) {
+        this.launchMode = launchMode;
+    }
 }

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/IDebugAdapterContext.java

@@ -101,4 +101,8 @@ public interface IDebugAdapterContext {
     StepFilters getStepFilters();
 
     IStackFrameManager getStackFrameManager();
+
+    LaunchMode getLaunchMode();
+
+    void setLaunchMode(LaunchMode launchMode);
 }

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/LaunchMode.java

@@ -0,0 +1,17 @@
+/*******************************************************************************
+* Copyright (c) 2018 Microsoft Corporation and others.
+* All rights reserved. This program and the accompanying materials
+* are made available under the terms of the Eclipse Public License v1.0
+* which accompanies this distribution, and is available at
+* http://www.eclipse.org/legal/epl-v10.html
+*
+* Contributors:
+*     Microsoft Corporation - initial API and implementation
+*******************************************************************************/
+
+package com.microsoft.java.debug.core.adapter;
+
+public enum LaunchMode {
+    DEBUG,
+    NO_DEBUG
+}

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/LaunchRequestHandler.java

@@ -46,6 +46,7 @@
 import com.microsoft.java.debug.core.adapter.IHotCodeReplaceProvider;
 import com.microsoft.java.debug.core.adapter.ISourceLookUpProvider;
 import com.microsoft.java.debug.core.adapter.IVirtualMachineManagerProvider;
+import com.microsoft.java.debug.core.adapter.LaunchMode;
 import com.microsoft.java.debug.core.adapter.ProcessConsole;
 import com.microsoft.java.debug.core.protocol.Events;
 import com.microsoft.java.debug.core.protocol.JsonUtils;
@@ -86,6 +87,7 @@ public CompletableFuture<Response> handle(Command command, Arguments arguments,
         context.setAttached(false);
         context.setSourcePaths(launchArguments.sourcePaths);
         context.setVmStopOnEntry(launchArguments.stopOnEntry);
+        context.setLaunchMode(launchArguments.noDebug ? LaunchMode.NO_DEBUG : LaunchMode.DEBUG);
         context.setMainClass(parseMainClassWithoutModuleName(launchArguments.mainClass));
         context.setStepFilters(launchArguments.stepFilters);
 

com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/protocol/Requests.java

@@ -70,6 +70,7 @@ public static class LaunchArguments extends LaunchBaseArguments {
         public String cwd;
         public Map<String, String> env;
         public boolean stopOnEntry;
+        public boolean noDebug = false;
         public CONSOLE console = CONSOLE.internalConsole;
     }