Support configuring the MaxRequestBodySize for the upload endpoint

Author: alexmg

service/Core/Configuration/ServiceConfig.cs

@@ -12,6 +12,12 @@ public class ServiceConfig
     /// </summary>
     public bool RunWebService { get; set; } = true;
 
+    /// <summary>
+    /// The maximum allowed size in bytes for a request body posted to the upload endpoint.
+    /// If not set, the default ASP.NET Core limit of 30 MB (~28.6 MiB) is applied.
+    /// </summary>
+    public long? MaxUploadRequestBodySize { get; set; } = null;
+
     /// <summary>
     /// Whether to run the asynchronous pipeline handlers
     /// Use these booleans to deploy the web service and the handlers on same/different VMs

service/Service.AspNetCore/WebAPIEndpoints.cs

@@ -7,10 +7,12 @@
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Http.Features;
 using Microsoft.AspNetCore.Http.HttpResults;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.AspNetCore.Routing;
 using Microsoft.Extensions.Logging;
+using Microsoft.KernelMemory.Configuration;
 using Microsoft.KernelMemory.Context;
 using Microsoft.KernelMemory.DocumentStorage;
 using Microsoft.KernelMemory.Service.AspNetCore.Models;
@@ -21,10 +23,11 @@ public static class WebAPIEndpoints
 {
     public static IEndpointRouteBuilder AddKernelMemoryEndpoints(
         this IEndpointRouteBuilder builder,
+        ServiceConfig serviceConfig,
         string apiPrefix = "/",
         IEndpointFilter? authFilter = null)
     {
-        builder.AddPostUploadEndpoint(apiPrefix, authFilter);
+        builder.AddPostUploadEndpoint(apiPrefix, authFilter, serviceConfig.MaxUploadRequestBodySize);
         builder.AddGetIndexesEndpoint(apiPrefix, authFilter);
         builder.AddDeleteIndexesEndpoint(apiPrefix, authFilter);
         builder.AddDeleteDocumentsEndpoint(apiPrefix, authFilter);
@@ -37,7 +40,7 @@ public static IEndpointRouteBuilder AddKernelMemoryEndpoints(
     }
 
     public static void AddPostUploadEndpoint(
-        this IEndpointRouteBuilder builder, string apiPrefix = "/", IEndpointFilter? authFilter = null)
+        this IEndpointRouteBuilder builder, string apiPrefix = "/", IEndpointFilter? authFilter = null, long? maxRequestBodySize = null)
     {
         RouteGroupBuilder group = builder.MapGroup(apiPrefix);
 
@@ -49,6 +52,13 @@ public static void AddPostUploadEndpoint(
                 IContextProvider contextProvider,
                 CancellationToken cancellationToken) =>
             {
+                if (maxRequestBodySize is not null
+                    && request.HttpContext.Features.Get<IHttpMaxRequestBodySizeFeature>() is { } feature)
+                {
+                    log.LogTrace("Max upload request body size set to {0} bytes", maxRequestBodySize);
+                    feature.MaxRequestBodySize = maxRequestBodySize;
+                }
+
                 log.LogTrace("New upload HTTP request, content length {0}", request.ContentLength);
 
                 // Note: .NET doesn't yet support binding multipart forms including data and files

service/Service/Program.cs

@@ -138,7 +138,7 @@ public static void Main(string[] args)
                 .Produces<ProblemDetails>(StatusCodes.Status403Forbidden);
 
             // Add HTTP endpoints using minimal API (https://learn.microsoft.com/aspnet/core/fundamentals/minimal-apis)
-            app.AddKernelMemoryEndpoints("/", authFilter);
+            app.AddKernelMemoryEndpoints(config.Service, "/", authFilter);
 
             // Health probe
             app.MapGet("/health", () => Results.Ok("Service is running."))

service/Service/appsettings.json

@@ -42,6 +42,9 @@
       // Whether to run the web service that allows to upload files and search memory
       // Use these booleans to deploy the web service and the handlers on same/different VMs
       "RunWebService": true,
+      // The maximum allowed size in bytes for a request body posted to the upload endpoint
+      // If not set, the default ASP.NET Core limit of 30 MB (~28.6 MiB) is applied
+      "MaxUploadRequestBodySize": null,
       // Whether to expose OpenAPI swagger UI at http://127.0.0.1:9001/swagger/index.html
       "OpenApiEnabled": false,
       // Whether to run the asynchronous pipeline handlers