Update SensitiveDataLogger for dual environment support (#865)

Modified `EnsureDevelopmentEnvironment `to check `DOTNET_ENVIRONMENT` if
`ASPNETCORE_ENVIRONMENT` is not set, and updated exception message.
Updated **SensitiveDataLoggerTests.cs** to distinguish between
environment variables. Added new test methods for different
environments. Renamed existing test methods for clarity. Updated
`Dispose` method to clear both environment variables.

## Motivation and Context (Why the change? What's the scenario?)
See https://github.com/microsoft/kernel-memory/issues/851

Author: marcominerva

service/Abstractions/Diagnostics/SensitiveDataLogger.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft. All rights reserved.
+// Copyright (c) Microsoft. All rights reserved.
 
 using System;
 using Microsoft.Extensions.Logging;
@@ -68,10 +68,14 @@ public static void LogSensitive(
 
     private static void EnsureDevelopmentEnvironment()
     {
-        var env = Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT");
+        const string AspNetCoreEnvVar = "ASPNETCORE_ENVIRONMENT";
+        const string DotNetEnvVar = "DOTNET_ENVIRONMENT";
+
+        // The ASPNETCORE_ENVIRONMENT environment variable has the precedence. If it does not exist, checks for DOTNET_ENVIRONMENT.
+        var env = Environment.GetEnvironmentVariable(AspNetCoreEnvVar) ?? Environment.GetEnvironmentVariable(DotNetEnvVar);
         if (!string.Equals(env, "Development", StringComparison.OrdinalIgnoreCase))
         {
-            throw new InvalidOperationException("Sensitive data logging can be enabled only in a development environment. Check ASPNETCORE_ENVIRONMENT env var.");
+            throw new InvalidOperationException($"Sensitive data logging can be enabled only in a development environment. Check {AspNetCoreEnvVar} or {DotNetEnvVar} env vars.");
         }
     }
 }

service/tests/Abstractions.UnitTests/Diagnostics/SensitiveDataLoggerTests.cs

@@ -6,7 +6,8 @@ namespace Microsoft.KM.Abstractions.UnitTests.Diagnostics;
 
 public sealed class SensitiveDataLoggerTests : IDisposable
 {
-    private const string EnvironmentVariableName = "ASPNETCORE_ENVIRONMENT";
+    private const string AspNetCoreEnvVar = "ASPNETCORE_ENVIRONMENT";
+    private const string DotNetEnvVar = "DOTNET_ENVIRONMENT";
 
     [Fact]
     public void ItIsDisabledByDefault()
@@ -17,13 +18,15 @@ public void ItIsDisabledByDefault()
 
     [Theory]
     [Trait("Category", "UnitTest")]
-    [InlineData("development")]
-    [InlineData("Development")]
-    public void ItCanBeEnabledInDevelopmentEnvironment(string environment)
+    [InlineData(AspNetCoreEnvVar, "development")]
+    [InlineData(AspNetCoreEnvVar, "Development")]
+    [InlineData(DotNetEnvVar, "development")]
+    [InlineData(DotNetEnvVar, "Development")]
+    public void ItCanBeEnabledInDevEnvironments(string envVar, string envType)
     {
         // Arrange
         Assert.False(SensitiveDataLogger.Enabled);
-        Environment.SetEnvironmentVariable(EnvironmentVariableName, environment);
+        Environment.SetEnvironmentVariable(envVar, envType);
 
         // Act
         SensitiveDataLogger.Enabled = true;
@@ -34,35 +37,47 @@ public void ItCanBeEnabledInDevelopmentEnvironment(string environment)
 
     [Theory]
     [Trait("Category", "UnitTest")]
-    [InlineData("staging")]
-    [InlineData("Staging")]
-    [InlineData("production")]
-    [InlineData("Production")]
-    [InlineData("any")]
-    public void ItCannotBeEnabledInNonDevelopmentEnvironments(string environment)
+    [InlineData(AspNetCoreEnvVar, "staging")]
+    [InlineData(AspNetCoreEnvVar, "Staging")]
+    [InlineData(AspNetCoreEnvVar, "production")]
+    [InlineData(AspNetCoreEnvVar, "Production")]
+    [InlineData(AspNetCoreEnvVar, "any")]
+    [InlineData(DotNetEnvVar, "staging")]
+    [InlineData(DotNetEnvVar, "Staging")]
+    [InlineData(DotNetEnvVar, "production")]
+    [InlineData(DotNetEnvVar, "Production")]
+    [InlineData(DotNetEnvVar, "any")]
+    public void ItCannotBeEnabledInNonDevEnvironments(string envVar, string envType)
     {
         // Arrange
         Assert.False(SensitiveDataLogger.Enabled);
-        Environment.SetEnvironmentVariable(EnvironmentVariableName, environment);
+        Environment.SetEnvironmentVariable(envVar, envType);
 
         // Act/Assert
         Assert.Throws<InvalidOperationException>(() => SensitiveDataLogger.Enabled = true);
     }
 
     [Theory]
     [Trait("Category", "UnitTest")]
-    [InlineData("development")]
-    [InlineData("Development")]
-    [InlineData("staging")]
-    [InlineData("Staging")]
-    [InlineData("production")]
-    [InlineData("Production")]
-    [InlineData("any")]
-    public void ItCanBeDisabledInAnyEnvironment(string environment)
+    [InlineData(AspNetCoreEnvVar, "development")]
+    [InlineData(AspNetCoreEnvVar, "Development")]
+    [InlineData(AspNetCoreEnvVar, "staging")]
+    [InlineData(AspNetCoreEnvVar, "Staging")]
+    [InlineData(AspNetCoreEnvVar, "production")]
+    [InlineData(AspNetCoreEnvVar, "Production")]
+    [InlineData(AspNetCoreEnvVar, "any")]
+    [InlineData(DotNetEnvVar, "development")]
+    [InlineData(DotNetEnvVar, "Development")]
+    [InlineData(DotNetEnvVar, "staging")]
+    [InlineData(DotNetEnvVar, "Staging")]
+    [InlineData(DotNetEnvVar, "production")]
+    [InlineData(DotNetEnvVar, "Production")]
+    [InlineData(DotNetEnvVar, "any")]
+    public void ItCanBeDisabledInAnyEnvironment(string envVar, string envType)
     {
         // Arrange
         Assert.False(SensitiveDataLogger.Enabled);
-        Environment.SetEnvironmentVariable(EnvironmentVariableName, environment);
+        Environment.SetEnvironmentVariable(envVar, envType);
 
         // Act
         SensitiveDataLogger.Enabled = false;
@@ -71,9 +86,41 @@ public void ItCanBeDisabledInAnyEnvironment(string environment)
         Assert.False(SensitiveDataLogger.Enabled);
     }
 
+    [Theory]
+    [Trait("Category", "UnitTest")]
+    [InlineData("development", "staging", false)]
+    [InlineData("Development", "Staging", false)]
+    [InlineData("development", "production", false)]
+    [InlineData("Development", "Production", false)]
+    [InlineData("staging", "development", true)]
+    [InlineData("Staging", "Development", true)]
+    [InlineData("production", "development", true)]
+    [InlineData("Production", "Development", true)]
+    public void AspNetCoreEnvTypeHasThePrecedence(string aspNetCoreEnvType, string dotNetEnvType, bool fail)
+    {
+        // Arrange
+        Assert.False(SensitiveDataLogger.Enabled);
+        Environment.SetEnvironmentVariable(AspNetCoreEnvVar, aspNetCoreEnvType);
+        Environment.SetEnvironmentVariable(DotNetEnvVar, dotNetEnvType);
+
+        if (fail)
+        {
+            Assert.Throws<InvalidOperationException>(() => SensitiveDataLogger.Enabled = true);
+        }
+        else
+        {
+            // Act
+            SensitiveDataLogger.Enabled = true;
+
+            // Assert
+            Assert.True(SensitiveDataLogger.Enabled);
+        }
+    }
+
     public void Dispose()
     {
-        Environment.SetEnvironmentVariable(EnvironmentVariableName, null);
+        Environment.SetEnvironmentVariable(AspNetCoreEnvVar, null);
+        Environment.SetEnvironmentVariable(DotNetEnvVar, null);
         SensitiveDataLogger.Enabled = false;
     }
 }