Fix 851 - Incorrect logic in SensitiveDataLogger (#852)

Author: dluc

service/Abstractions/Diagnostics/SensitiveDataLogger.cs

@@ -12,21 +12,14 @@ public static class SensitiveDataLogger
 
     public static bool Enabled
     {
-        get
-        {
-            return s_enabled;
-        }
+        get => s_enabled;
         set
         {
-            var env = Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT");
-            if (!string.Equals(env, "Development", StringComparison.OrdinalIgnoreCase))
-            {
-#pragma warning disable CA2201
-                throw new ApplicationException("Sensitive data logging can be enabled only in a development environment. Check ASPNETCORE_ENVIRONMENT env var.");
-#pragma warning restore CA0000
-            }
-
-            s_enabled = value && string.Equals(env, "Development", StringComparison.OrdinalIgnoreCase);
+            if (s_enabled == value) { return; }
+
+            if (value) { EnsureDevelopmentEnvironment(); }
+
+            s_enabled = value;
         }
     }
 
@@ -72,4 +65,13 @@ public static void LogSensitive(
 
         logger.Log(LoggingLevel, eventId, message, args);
     }
+
+    private static void EnsureDevelopmentEnvironment()
+    {
+        var env = Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT");
+        if (!string.Equals(env, "Development", StringComparison.OrdinalIgnoreCase))
+        {
+            throw new InvalidOperationException("Sensitive data logging can be enabled only in a development environment. Check ASPNETCORE_ENVIRONMENT env var.");
+        }
+    }
 }