Little optimization with BinaryData in TextPartitionHandler #886
Closed
marcominerva
started this conversation in
2. Feature requests
Replies: 1 comment 1 reply
-
good idea 👍 |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
@dluc Before making a PR, I'm asking here because, based on the comment, I don't know if you have already tried. The following check:
kernel-memory/service/Core/Handlers/TextPartitioningHandler.cs
Lines 122 to 123 in ad4a996
Could be replaced with
partitionContent.Length == 0
orpartitionContent.IsEmpty
? In this way, we avoid a copy.Beta Was this translation helpful? Give feedback.
All reactions