Skip to content

Commit ea0782a

Browse files
authored
Merge pull request #132 from andreaTP/use-tryadd
Use TryAdd when setting Content-Type
2 parents 782c4c5 + 9abd775 commit ea0782a

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
## [1.3.5] - 2023-10-05
11+
12+
### Changed
13+
14+
- Uses headers try add when setting the content type.
15+
1016
## [1.3.4] - 2023-10-04
1117

1218
### Changed

src/Microsoft.Kiota.Abstractions.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<PackageProjectUrl>https://aka.ms/kiota/docs</PackageProjectUrl>
1515
<EmbedUntrackedSources>true</EmbedUntrackedSources>
1616
<Deterministic>true</Deterministic>
17-
<VersionPrefix>1.3.4</VersionPrefix>
17+
<VersionPrefix>1.3.5</VersionPrefix>
1818
<VersionSuffix></VersionSuffix>
1919
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
2020
<SignAssembly>false</SignAssembly>

src/RequestInformation.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ public void SetStreamContent(Stream content)
195195
using var activity = _activitySource?.StartActivity(nameof(SetStreamContent));
196196
SetRequestType(content, activity);
197197
Content = content;
198-
Headers.Add(ContentTypeHeader, BinaryContentType);
198+
Headers.TryAdd(ContentTypeHeader, BinaryContentType);
199199
}
200200
private static ActivitySource _activitySource = new(typeof(RequestInformation).Namespace!);
201201
/// <summary>
@@ -211,7 +211,7 @@ public void SetContentFromParsable<T>(IRequestAdapter requestAdapter, string con
211211
using var writer = GetSerializationWriter(requestAdapter, contentType, items);
212212
SetRequestType(items.FirstOrDefault(static x => x != null), activity);
213213
writer.WriteCollectionOfObjectValues(null, items);
214-
Headers.Add(ContentTypeHeader, contentType);
214+
Headers.TryAdd(ContentTypeHeader, contentType);
215215
Content = writer.GetSerializedContent();
216216
}
217217
/// <summary>
@@ -232,7 +232,7 @@ public void SetContentFromParsable<T>(IRequestAdapter requestAdapter, string con
232232
mpBody.RequestAdapter = requestAdapter;
233233
}
234234
writer.WriteObjectValue(null, item);
235-
Headers.Add(ContentTypeHeader, contentType);
235+
Headers.TryAdd(ContentTypeHeader, contentType);
236236
Content = writer.GetSerializedContent();
237237
}
238238
private static void SetRequestType(object? result, Activity? activity)
@@ -261,7 +261,7 @@ public void SetContentFromScalarCollection<T>(IRequestAdapter requestAdapter, st
261261
using var writer = GetSerializationWriter(requestAdapter, contentType, items);
262262
SetRequestType(items.FirstOrDefault(static x => x != null), activity);
263263
writer.WriteCollectionOfPrimitiveValues(null, items);
264-
Headers.Add(ContentTypeHeader, contentType);
264+
Headers.TryAdd(ContentTypeHeader, contentType);
265265
Content = writer.GetSerializedContent();
266266
}
267267
/// <summary>
@@ -323,7 +323,7 @@ public void SetContentFromScalar<T>(IRequestAdapter requestAdapter, string conte
323323
default:
324324
throw new InvalidOperationException($"error serialization data value with unknown type {item?.GetType()}");
325325
}
326-
Headers.Add(ContentTypeHeader, contentType);
326+
Headers.TryAdd(ContentTypeHeader, contentType);
327327
Content = writer.GetSerializedContent();
328328
}
329329
}

0 commit comments

Comments
 (0)