refactor: move negative retry interval check to getRetryAfter method

Move the negative value handling from retryRequest to getRetryAfter method
as suggested in code review. This ensures getRetryAfter never returns a
negative value, making the API more robust.

- Move check from retryRequest to getRetryAfter
- Update test to verify getRetryAfter returns 1-10ms instead of -1
- Maintain same behavior: random delay between 1-10ms for negative values

Co-authored-by: baywet <[email protected]>

Author: Copilot

components/http/okHttp/src/main/java/com/microsoft/kiota/http/middleware/RetryHandler.java

@@ -110,10 +110,6 @@ && isBuffered(request)
 
         if (shouldRetry) {
             long retryInterval = getRetryAfter(response, retryOption.delay(), executionCount);
-            // Ensure minimum delay if retry interval is negative
-            if (retryInterval < 0) {
-                retryInterval = 1 + (long) (Math.random() * 9); // Random delay between 1-10ms
-            }
             span.setAttribute(HTTP_REQUEST_RESEND_DELAY, Math.round(retryInterval / 1000f));
             try {
                 Thread.sleep(retryInterval);
@@ -142,7 +138,13 @@ long getRetryAfter(Response response, long delay, int executionCount) {
         } else if (retryDelay == -1) {
             retryDelay = exponentialBackOffDelay(delay, executionCount);
         }
-        return (long) Math.min(retryDelay, RetryHandlerOption.MAX_DELAY * DELAY_MILLISECONDS);
+        long result =
+                (long) Math.min(retryDelay, RetryHandlerOption.MAX_DELAY * DELAY_MILLISECONDS);
+        // Ensure minimum delay if retry interval is negative
+        if (result < 0) {
+            result = 1 + (long) (Math.random() * 9); // Random delay between 1-10ms
+        }
+        return result;
     }
 
     /**

components/http/okHttp/src/test/java/com/microsoft/kiota/http/middleware/RetryHandlerTest.java

@@ -71,15 +71,17 @@ void testTryParseTimeHeader(String headerValue, double expectedDelay) {
     }
 
     @Test
-    void testGetRetryAfterReturnsNegativeWhenHeaderParsingFails() {
+    void testGetRetryAfterHandlesNegativeValues() {
         // Create a mock response with a Retry-After header that will fail parsing
         Response mockResponse = mock(Response.class);
         when(mockResponse.header("Retry-After")).thenReturn("invalid");
         when(mockResponse.code()).thenReturn(429);
 
-        // getRetryAfter should return -1 when parsing fails but header exists
+        // getRetryAfter should return a value between 1-10ms when parsing fails
         long retryAfter = retryHandler.getRetryAfter(mockResponse, 3, 1);
-        assertEquals(-1, retryAfter, "Expected -1 when Retry-After header parsing fails");
+        assertTrue(
+                retryAfter >= 1 && retryAfter <= 10,
+                "Expected retry interval between 1-10ms, got " + retryAfter);
     }
 
     @Test