Ensures 3XX responses without location header do not throw #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrueastman
left a comment
andrueastman
left a comment
There was a problem hiding this comment.
Any chance you also align the commit message format for the purposes of release/changelog generation as outlined at https://github.com/microsoft/kiota-java/blob/main/CONTRIBUTING.md#commit-message-format
components/http/okHttp/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java
Outdated
Show resolved
Hide resolved
baywet
approved these changes
Feb 19, 2025
Member
|
@andrueastman for final review and merge (please squash with a conventional commit so we trigger a release here) |
Fixed violations as per PR gate recommendations Sonar recommendations Addressing sonar issues Gradle apply Updated test to cover multiple values Added another test Updated value sources Updated test Removed unnecessary test Updates Updated tests fix: Ensure 3XX responses without location header do not throw fix: Ensure 3XX responses without location header do not throw
timayabi2020
force-pushed
the
tm/fix-3xx-location-header
branch
from
802ed12 to
214a624
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1132