Skip to content

Commit 9ed37cf

Browse files
Revert "check for changed .rs files before semver checks" (#168)
This reverts commit fcb17a1 (part of #165). The change (intended at speeding things up) is over-eager, and makes the entire semver-checks workflow ineffective. By reverting it out, we make sure that we are actually using the more effective version. At some point in the future, I might try to bring back some version of this to speed things up.
1 parent c7f8fbf commit 9ed37cf

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

.github/workflows/semver-checks.yml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,30 +25,15 @@ jobs:
2525
uses: actions/checkout@v4
2626
- name: Ensure that the main branch is fetched
2727
run: git fetch origin main:main
28-
- name: Check for changed .rs files
29-
id: check_rs_changes
30-
run: |
31-
git fetch origin main:main
32-
CHANGED_RS_FILES=$(git diff --name-only origin/main...HEAD | grep '\.rs$' || true)
33-
echo "Changed .rs files:"
34-
echo "$CHANGED_RS_FILES"
35-
if [ -z "$CHANGED_RS_FILES" ]; then
36-
echo "rs_changes=false" >> "$GITHUB_OUTPUT"
37-
else
38-
echo "rs_changes=true" >> "$GITHUB_OUTPUT"
39-
fi
4028
- name: Set up Rust
41-
if: steps.check_rs_changes.outputs.rs_changes == 'true'
4229
run: |
4330
rustup toolchain install $(awk -F'"' '/channel/{print $2}' rust-toolchain.toml) --profile minimal --no-self-update
4431
- name: Set up cargo-semver-checks
45-
if: steps.check_rs_changes.outputs.rs_changes == 'true'
4632
run: |
4733
curl -L --proto '=https' --tlsv1.2 -sSf https://github.com/obi1kenobi/cargo-semver-checks/releases/latest/download/cargo-semver-checks-x86_64-unknown-linux-gnu.tar.gz | tar xzvf -
4834
mv cargo-semver-checks ~/.cargo/bin
4935
- name: Check semver match against the main branch
5036
id: semver_check
51-
if: steps.check_rs_changes.outputs.rs_changes == 'true'
5237
run: |
5338
# TODO(jayb): we are temporarily preventing a failure in semver-checks
5439
# from showing up as a `X`, but instead triggering a comment on the

0 commit comments

Comments
 (0)