Migrate ResourceHealthService from IHttpClientService to IHttpClientFactory (#1546)

Author: anuchandy

tools/Azure.Mcp.Tools.ResourceHealth/src/Services/ResourceHealthService.cs

@@ -7,17 +7,16 @@
 using Azure.Mcp.Core.Services.Azure;
 using Azure.Mcp.Core.Services.Azure.Subscription;
 using Azure.Mcp.Core.Services.Azure.Tenant;
-using Azure.Mcp.Core.Services.Http;
 using Azure.Mcp.Tools.ResourceHealth.Models;
 using Azure.Mcp.Tools.ResourceHealth.Models.Internal;
 
 namespace Azure.Mcp.Tools.ResourceHealth.Services;
 
-public class ResourceHealthService(ISubscriptionService subscriptionService, ITenantService tenantService, IHttpClientService httpClientService)
+public class ResourceHealthService(ISubscriptionService subscriptionService, ITenantService tenantService, IHttpClientFactory httpClientFactory)
     : BaseAzureService(tenantService), IResourceHealthService
 {
     private readonly ISubscriptionService _subscriptionService = subscriptionService ?? throw new ArgumentNullException(nameof(subscriptionService));
-    private readonly IHttpClientService _httpClientService = httpClientService ?? throw new ArgumentNullException(nameof(httpClientService));
+    private readonly IHttpClientFactory _httpClientFactory = httpClientFactory ?? throw new ArgumentNullException(nameof(httpClientFactory));
 
     private const string AzureManagementBaseUrl = "https://management.azure.com";
     private const string ResourceHealthApiVersion = "2025-05-01";
@@ -36,7 +35,8 @@ public async Task<AvailabilityStatus> GetAvailabilityStatusAsync(
                 new TokenRequestContext([$"{AzureManagementBaseUrl}/.default"]),
                 cancellationToken);
 
-            using var client = _httpClientService.CreateClient(new Uri(AzureManagementBaseUrl));
+            var client = _httpClientFactory.CreateClient();
+            client.BaseAddress = new Uri(AzureManagementBaseUrl);
             client.DefaultRequestHeaders.Authorization = new System.Net.Http.Headers.AuthenticationHeaderValue("Bearer", token.Token);
 
             var url = $"{resourceId}/providers/Microsoft.ResourceHealth/availabilityStatuses/current?api-version={ResourceHealthApiVersion}";
@@ -83,7 +83,8 @@ public async Task<List<AvailabilityStatus>> ListAvailabilityStatusesAsync(
                 new TokenRequestContext([$"{AzureManagementBaseUrl}/.default"]),
                 cancellationToken);
 
-            using var client = _httpClientService.CreateClient(new Uri(AzureManagementBaseUrl));
+            var client = _httpClientFactory.CreateClient();
+            client.BaseAddress = new Uri(AzureManagementBaseUrl);
             client.DefaultRequestHeaders.Authorization = new System.Net.Http.Headers.AuthenticationHeaderValue("Bearer", token.Token);
 
             var url = resourceGroup != null
@@ -137,7 +138,8 @@ public async Task<List<ServiceHealthEvent>> ListServiceHealthEventsAsync(
                 new TokenRequestContext([$"{AzureManagementBaseUrl}/.default"]),
                 cancellationToken);
 
-            using var client = _httpClientService.CreateClient(new Uri(AzureManagementBaseUrl));
+            var client = _httpClientFactory.CreateClient();
+            client.BaseAddress = new Uri(AzureManagementBaseUrl);
             client.DefaultRequestHeaders.Authorization = new System.Net.Http.Headers.AuthenticationHeaderValue("Bearer", token.Token);
 
             // Build OData filter - using correct property paths for Azure Resource Health API