Skip to content

Commit 1d28ea2

Browse files
ranjeshjteaP
andcommitted
More InfoBarPanel API udpates (#3739)
* update API names * update to use all the padding/margin properties * Update for PR comments. Co-authored-by: Tammy Paine <30241445+teaP@users.noreply.github.com>
1 parent 38a38d9 commit 1d28ea2

File tree

6 files changed

+112
-101
lines changed

6 files changed

+112
-101
lines changed

dev/Generated/InfoBarPanel.properties.cpp

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ namespace winrt::Microsoft::UI::Xaml::Controls::Primitives
1313

1414
#include "InfoBarPanel.g.cpp"
1515

16-
GlobalDependencyProperty InfoBarPanelProperties::s_PaddingInHorizontalOrientationProperty{ nullptr };
17-
GlobalDependencyProperty InfoBarPanelProperties::s_PaddingInVerticalOrientationProperty{ nullptr };
18-
GlobalDependencyProperty InfoBarPanelProperties::s_SpacingInHorizontalOrientationProperty{ nullptr };
19-
GlobalDependencyProperty InfoBarPanelProperties::s_SpacingInVerticalOrientationProperty{ nullptr };
16+
GlobalDependencyProperty InfoBarPanelProperties::s_HorizontalOrientationMarginProperty{ nullptr };
17+
GlobalDependencyProperty InfoBarPanelProperties::s_HorizontalOrientationPaddingProperty{ nullptr };
18+
GlobalDependencyProperty InfoBarPanelProperties::s_VerticalOrientationMarginProperty{ nullptr };
19+
GlobalDependencyProperty InfoBarPanelProperties::s_VerticalOrientationPaddingProperty{ nullptr };
2020

2121
InfoBarPanelProperties::InfoBarPanelProperties()
2222
{
@@ -25,104 +25,104 @@ InfoBarPanelProperties::InfoBarPanelProperties()
2525

2626
void InfoBarPanelProperties::EnsureProperties()
2727
{
28-
if (!s_PaddingInHorizontalOrientationProperty)
28+
if (!s_HorizontalOrientationMarginProperty)
2929
{
30-
s_PaddingInHorizontalOrientationProperty =
30+
s_HorizontalOrientationMarginProperty =
3131
InitializeDependencyProperty(
32-
L"PaddingInHorizontalOrientation",
32+
L"HorizontalOrientationMargin",
3333
winrt::name_of<winrt::Thickness>(),
3434
winrt::name_of<winrt::InfoBarPanel>(),
35-
false /* isAttached */,
35+
true /* isAttached */,
3636
ValueHelper<winrt::Thickness>::BoxedDefaultValue(),
3737
nullptr);
3838
}
39-
if (!s_PaddingInVerticalOrientationProperty)
39+
if (!s_HorizontalOrientationPaddingProperty)
4040
{
41-
s_PaddingInVerticalOrientationProperty =
41+
s_HorizontalOrientationPaddingProperty =
4242
InitializeDependencyProperty(
43-
L"PaddingInVerticalOrientation",
43+
L"HorizontalOrientationPadding",
4444
winrt::name_of<winrt::Thickness>(),
4545
winrt::name_of<winrt::InfoBarPanel>(),
4646
false /* isAttached */,
4747
ValueHelper<winrt::Thickness>::BoxedDefaultValue(),
4848
nullptr);
4949
}
50-
if (!s_SpacingInHorizontalOrientationProperty)
50+
if (!s_VerticalOrientationMarginProperty)
5151
{
52-
s_SpacingInHorizontalOrientationProperty =
52+
s_VerticalOrientationMarginProperty =
5353
InitializeDependencyProperty(
54-
L"SpacingInHorizontalOrientation",
54+
L"VerticalOrientationMargin",
5555
winrt::name_of<winrt::Thickness>(),
5656
winrt::name_of<winrt::InfoBarPanel>(),
5757
true /* isAttached */,
5858
ValueHelper<winrt::Thickness>::BoxedDefaultValue(),
5959
nullptr);
6060
}
61-
if (!s_SpacingInVerticalOrientationProperty)
61+
if (!s_VerticalOrientationPaddingProperty)
6262
{
63-
s_SpacingInVerticalOrientationProperty =
63+
s_VerticalOrientationPaddingProperty =
6464
InitializeDependencyProperty(
65-
L"SpacingInVerticalOrientation",
65+
L"VerticalOrientationPadding",
6666
winrt::name_of<winrt::Thickness>(),
6767
winrt::name_of<winrt::InfoBarPanel>(),
68-
true /* isAttached */,
68+
false /* isAttached */,
6969
ValueHelper<winrt::Thickness>::BoxedDefaultValue(),
7070
nullptr);
7171
}
7272
}
7373

7474
void InfoBarPanelProperties::ClearProperties()
7575
{
76-
s_PaddingInHorizontalOrientationProperty = nullptr;
77-
s_PaddingInVerticalOrientationProperty = nullptr;
78-
s_SpacingInHorizontalOrientationProperty = nullptr;
79-
s_SpacingInVerticalOrientationProperty = nullptr;
76+
s_HorizontalOrientationMarginProperty = nullptr;
77+
s_HorizontalOrientationPaddingProperty = nullptr;
78+
s_VerticalOrientationMarginProperty = nullptr;
79+
s_VerticalOrientationPaddingProperty = nullptr;
8080
}
8181

82-
void InfoBarPanelProperties::PaddingInHorizontalOrientation(winrt::Thickness const& value)
82+
83+
void InfoBarPanelProperties::SetHorizontalOrientationMargin(winrt::DependencyObject const& target, winrt::Thickness const& value)
8384
{
84-
[[gsl::suppress(con)]]
85-
{
86-
static_cast<InfoBarPanel*>(this)->SetValue(s_PaddingInHorizontalOrientationProperty, ValueHelper<winrt::Thickness>::BoxValueIfNecessary(value));
87-
}
85+
target.SetValue(s_HorizontalOrientationMarginProperty, ValueHelper<winrt::Thickness>::BoxValueIfNecessary(value));
8886
}
8987

90-
winrt::Thickness InfoBarPanelProperties::PaddingInHorizontalOrientation()
88+
winrt::Thickness InfoBarPanelProperties::GetHorizontalOrientationMargin(winrt::DependencyObject const& target)
9189
{
92-
return ValueHelper<winrt::Thickness>::CastOrUnbox(static_cast<InfoBarPanel*>(this)->GetValue(s_PaddingInHorizontalOrientationProperty));
90+
return ValueHelper<winrt::Thickness>::CastOrUnbox(target.GetValue(s_HorizontalOrientationMarginProperty));
9391
}
9492

95-
void InfoBarPanelProperties::PaddingInVerticalOrientation(winrt::Thickness const& value)
93+
void InfoBarPanelProperties::HorizontalOrientationPadding(winrt::Thickness const& value)
9694
{
9795
[[gsl::suppress(con)]]
9896
{
99-
static_cast<InfoBarPanel*>(this)->SetValue(s_PaddingInVerticalOrientationProperty, ValueHelper<winrt::Thickness>::BoxValueIfNecessary(value));
97+
static_cast<InfoBarPanel*>(this)->SetValue(s_HorizontalOrientationPaddingProperty, ValueHelper<winrt::Thickness>::BoxValueIfNecessary(value));
10098
}
10199
}
102100

103-
winrt::Thickness InfoBarPanelProperties::PaddingInVerticalOrientation()
101+
winrt::Thickness InfoBarPanelProperties::HorizontalOrientationPadding()
104102
{
105-
return ValueHelper<winrt::Thickness>::CastOrUnbox(static_cast<InfoBarPanel*>(this)->GetValue(s_PaddingInVerticalOrientationProperty));
103+
return ValueHelper<winrt::Thickness>::CastOrUnbox(static_cast<InfoBarPanel*>(this)->GetValue(s_HorizontalOrientationPaddingProperty));
106104
}
107105

108106

109-
void InfoBarPanelProperties::SetSpacingInHorizontalOrientation(winrt::DependencyObject const& target, winrt::Thickness const& value)
107+
void InfoBarPanelProperties::SetVerticalOrientationMargin(winrt::DependencyObject const& target, winrt::Thickness const& value)
110108
{
111-
target.SetValue(s_SpacingInHorizontalOrientationProperty, ValueHelper<winrt::Thickness>::BoxValueIfNecessary(value));
109+
target.SetValue(s_VerticalOrientationMarginProperty, ValueHelper<winrt::Thickness>::BoxValueIfNecessary(value));
112110
}
113111

114-
winrt::Thickness InfoBarPanelProperties::GetSpacingInHorizontalOrientation(winrt::DependencyObject const& target)
112+
winrt::Thickness InfoBarPanelProperties::GetVerticalOrientationMargin(winrt::DependencyObject const& target)
115113
{
116-
return ValueHelper<winrt::Thickness>::CastOrUnbox(target.GetValue(s_SpacingInHorizontalOrientationProperty));
114+
return ValueHelper<winrt::Thickness>::CastOrUnbox(target.GetValue(s_VerticalOrientationMarginProperty));
117115
}
118116

119-
120-
void InfoBarPanelProperties::SetSpacingInVerticalOrientation(winrt::DependencyObject const& target, winrt::Thickness const& value)
117+
void InfoBarPanelProperties::VerticalOrientationPadding(winrt::Thickness const& value)
121118
{
122-
target.SetValue(s_SpacingInVerticalOrientationProperty, ValueHelper<winrt::Thickness>::BoxValueIfNecessary(value));
119+
[[gsl::suppress(con)]]
120+
{
121+
static_cast<InfoBarPanel*>(this)->SetValue(s_VerticalOrientationPaddingProperty, ValueHelper<winrt::Thickness>::BoxValueIfNecessary(value));
122+
}
123123
}
124124

125-
winrt::Thickness InfoBarPanelProperties::GetSpacingInVerticalOrientation(winrt::DependencyObject const& target)
125+
winrt::Thickness InfoBarPanelProperties::VerticalOrientationPadding()
126126
{
127-
return ValueHelper<winrt::Thickness>::CastOrUnbox(target.GetValue(s_SpacingInVerticalOrientationProperty));
127+
return ValueHelper<winrt::Thickness>::CastOrUnbox(static_cast<InfoBarPanel*>(this)->GetValue(s_VerticalOrientationPaddingProperty));
128128
}

dev/Generated/InfoBarPanel.properties.h

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,27 +9,27 @@ class InfoBarPanelProperties
99
public:
1010
InfoBarPanelProperties();
1111

12-
void PaddingInHorizontalOrientation(winrt::Thickness const& value);
13-
winrt::Thickness PaddingInHorizontalOrientation();
12+
static void SetHorizontalOrientationMargin(winrt::DependencyObject const& target, winrt::Thickness const& value);
13+
static winrt::Thickness GetHorizontalOrientationMargin(winrt::DependencyObject const& target);
1414

15-
void PaddingInVerticalOrientation(winrt::Thickness const& value);
16-
winrt::Thickness PaddingInVerticalOrientation();
15+
void HorizontalOrientationPadding(winrt::Thickness const& value);
16+
winrt::Thickness HorizontalOrientationPadding();
1717

18-
static void SetSpacingInHorizontalOrientation(winrt::DependencyObject const& target, winrt::Thickness const& value);
19-
static winrt::Thickness GetSpacingInHorizontalOrientation(winrt::DependencyObject const& target);
18+
static void SetVerticalOrientationMargin(winrt::DependencyObject const& target, winrt::Thickness const& value);
19+
static winrt::Thickness GetVerticalOrientationMargin(winrt::DependencyObject const& target);
2020

21-
static void SetSpacingInVerticalOrientation(winrt::DependencyObject const& target, winrt::Thickness const& value);
22-
static winrt::Thickness GetSpacingInVerticalOrientation(winrt::DependencyObject const& target);
21+
void VerticalOrientationPadding(winrt::Thickness const& value);
22+
winrt::Thickness VerticalOrientationPadding();
2323

24-
static winrt::DependencyProperty PaddingInHorizontalOrientationProperty() { return s_PaddingInHorizontalOrientationProperty; }
25-
static winrt::DependencyProperty PaddingInVerticalOrientationProperty() { return s_PaddingInVerticalOrientationProperty; }
26-
static winrt::DependencyProperty SpacingInHorizontalOrientationProperty() { return s_SpacingInHorizontalOrientationProperty; }
27-
static winrt::DependencyProperty SpacingInVerticalOrientationProperty() { return s_SpacingInVerticalOrientationProperty; }
24+
static winrt::DependencyProperty HorizontalOrientationMarginProperty() { return s_HorizontalOrientationMarginProperty; }
25+
static winrt::DependencyProperty HorizontalOrientationPaddingProperty() { return s_HorizontalOrientationPaddingProperty; }
26+
static winrt::DependencyProperty VerticalOrientationMarginProperty() { return s_VerticalOrientationMarginProperty; }
27+
static winrt::DependencyProperty VerticalOrientationPaddingProperty() { return s_VerticalOrientationPaddingProperty; }
2828

29-
static GlobalDependencyProperty s_PaddingInHorizontalOrientationProperty;
30-
static GlobalDependencyProperty s_PaddingInVerticalOrientationProperty;
31-
static GlobalDependencyProperty s_SpacingInHorizontalOrientationProperty;
32-
static GlobalDependencyProperty s_SpacingInVerticalOrientationProperty;
29+
static GlobalDependencyProperty s_HorizontalOrientationMarginProperty;
30+
static GlobalDependencyProperty s_HorizontalOrientationPaddingProperty;
31+
static GlobalDependencyProperty s_VerticalOrientationMarginProperty;
32+
static GlobalDependencyProperty s_VerticalOrientationPaddingProperty;
3333

3434
static void EnsureProperties();
3535
static void ClearProperties();

dev/InfoBar/InfoBar.idl

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -117,19 +117,19 @@ unsealed runtimeclass InfoBarPanel : Windows.UI.Xaml.Controls.Panel
117117
{
118118
InfoBarPanel();
119119

120-
Windows.UI.Xaml.Thickness PaddingInHorizontalOrientation;
121-
static Windows.UI.Xaml.DependencyProperty PaddingInHorizontalOrientationProperty{ get; };
120+
Windows.UI.Xaml.Thickness HorizontalOrientationPadding;
121+
static Windows.UI.Xaml.DependencyProperty HorizontalOrientationPaddingProperty{ get; };
122122

123-
Windows.UI.Xaml.Thickness PaddingInVerticalOrientation;
124-
static Windows.UI.Xaml.DependencyProperty PaddingInVerticalOrientationProperty{ get; };
123+
Windows.UI.Xaml.Thickness VerticalOrientationPadding;
124+
static Windows.UI.Xaml.DependencyProperty VerticalOrientationPaddingProperty{ get; };
125125

126-
static void SetSpacingInHorizontalOrientation(Windows.UI.Xaml.DependencyObject object, Windows.UI.Xaml.Thickness value);
127-
static Windows.UI.Xaml.Thickness GetSpacingInHorizontalOrientation(Windows.UI.Xaml.DependencyObject object);
128-
static Windows.UI.Xaml.DependencyProperty SpacingInHorizontalOrientationProperty{ get; };
126+
static void SetHorizontalOrientationMargin(Windows.UI.Xaml.DependencyObject object, Windows.UI.Xaml.Thickness value);
127+
static Windows.UI.Xaml.Thickness GetHorizontalOrientationMargin(Windows.UI.Xaml.DependencyObject object);
128+
static Windows.UI.Xaml.DependencyProperty HorizontalOrientationMarginProperty{ get; };
129129

130-
static void SetSpacingInVerticalOrientation(Windows.UI.Xaml.DependencyObject object, Windows.UI.Xaml.Thickness value);
131-
static Windows.UI.Xaml.Thickness GetSpacingInVerticalOrientation(Windows.UI.Xaml.DependencyObject object);
132-
static Windows.UI.Xaml.DependencyProperty SpacingInVerticalOrientationProperty{ get; };
130+
static void SetVerticalOrientationMargin(Windows.UI.Xaml.DependencyObject object, Windows.UI.Xaml.Thickness value);
131+
static Windows.UI.Xaml.Thickness GetVerticalOrientationMargin(Windows.UI.Xaml.DependencyObject object);
132+
static Windows.UI.Xaml.DependencyProperty VerticalOrientationMarginProperty{ get; };
133133
}
134134

135135
}

dev/InfoBar/InfoBar.xaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -136,14 +136,14 @@
136136
<primitives:InfoBarPanel
137137
Grid.Column="1"
138138
Margin="{StaticResource InfoBarPanelMargin}"
139-
PaddingInHorizontalOrientation="{StaticResource InfoBarPanelPaddingInHorizontalOrientation}"
140-
PaddingInVerticalOrientation="{StaticResource InfoBarPanelPaddingInVerticalOrientation}">
139+
HorizontalOrientationPadding="{StaticResource InfoBarPanelHorizontalOrientationPadding}"
140+
VerticalOrientationPadding="{StaticResource InfoBarPanelVerticalOrientationPadding}">
141141

142142
<TextBlock x:Name="Title"
143143
Text="{TemplateBinding Title}"
144144
Foreground="{ThemeResource InfoBarTitleForeground}"
145-
primitives:InfoBarPanel.SpacingInHorizontalOrientation="{StaticResource InfoBarTitleSpacingInHorizontalOrientation}"
146-
primitives:InfoBarPanel.SpacingInVerticalOrientation="{StaticResource InfoBarTitleSpacingInVerticalOrientation}"
145+
primitives:InfoBarPanel.HorizontalOrientationMargin="{StaticResource InfoBarTitleHorizontalOrientationMargin}"
146+
primitives:InfoBarPanel.VerticalOrientationMargin="{StaticResource InfoBarTitleVerticalOrientationMargin}"
147147
TextWrapping="WrapWholeWords"
148148
AutomationProperties.LandmarkType="Navigation"
149149
FontWeight="{StaticResource InfoBarTitleFontWeight}"
@@ -152,15 +152,15 @@
152152
<TextBlock x:Name="Message"
153153
Text="{TemplateBinding Message}"
154154
Foreground="{ThemeResource InfoBarMessageForeground}"
155-
primitives:InfoBarPanel.SpacingInHorizontalOrientation="{StaticResource InfoBarMessageSpacingInHorizontalOrientation}"
156-
primitives:InfoBarPanel.SpacingInVerticalOrientation="{StaticResource InfoBarMessageSpacingInVerticalOrientation}"
155+
primitives:InfoBarPanel.HorizontalOrientationMargin="{StaticResource InfoBarMessageHorizontalOrientationMargin}"
156+
primitives:InfoBarPanel.VerticalOrientationMargin="{StaticResource InfoBarMessageVerticalOrientationMargin}"
157157
TextWrapping="WrapWholeWords"
158158
FontWeight="{StaticResource InfoBarMessageFontWeight}"
159159
FontSize="{StaticResource InfoBarMessageFontSize}"/>
160160

161161
<ContentPresenter
162-
primitives:InfoBarPanel.SpacingInHorizontalOrientation="{StaticResource InfoBarActionSpacingInHorizontalOrientation}"
163-
primitives:InfoBarPanel.SpacingInVerticalOrientation="{StaticResource InfoBarActionSpacingInVerticalOrientation}"
162+
primitives:InfoBarPanel.HorizontalOrientationMargin="{StaticResource InfoBarActionHorizontalOrientationMargin}"
163+
primitives:InfoBarPanel.VerticalOrientationMargin="{StaticResource InfoBarActionVerticalOrientationMargin}"
164164
VerticalAlignment="Top"
165165
Content="{TemplateBinding ActionButton}">
166166

0 commit comments

Comments
 (0)