More silo enlightenment (#5220)

Attach to the right silo when uninitializing a connection. Otherwise, the security context could be freed in a silo that's not where the context was allocated.

Author: csujedihy

src/core/connection.c

@@ -309,6 +309,11 @@ QuicConnFree(
     )
 {
     QUIC_PARTITION* Partition = Connection->Partition;
+#ifdef QUIC_SILO
+    QUIC_SILO Silo = NULL;
+    QuicConfigurationAttachSilo(Connection->Configuration);
+#endif
+
     CXPLAT_FRE_ASSERT(!Connection->State.Freed);
     CXPLAT_TEL_ASSERT(Connection->RefCount == 0);
     if (Connection->State.ExternalOwner) {
@@ -369,6 +374,15 @@ QuicConnFree(
     QuicDatagramSendShutdown(&Connection->Datagram);
     QuicDatagramUninitialize(&Connection->Datagram);
     if (Connection->Configuration != NULL) {
+#ifdef QUIC_SILO
+        //
+        // Take a ref on the silo before releasing the configuration
+        // to prevent the silo from being destroyed while we are still
+        // holding onto the thread to clean up other stuff for this connection.
+        //
+        Silo = Connection->Configuration->Silo;
+        QuicSiloAddRef(Silo);
+#endif
         QuicConfigurationRelease(Connection->Configuration);
         Connection->Configuration = NULL;
     }
@@ -408,6 +422,10 @@ QuicConnFree(
     InterlockedDecrement(&MsQuicLib.ConnectionCount);
 #endif
     QuicPerfCounterDecrement(Partition, QUIC_PERF_COUNTER_CONN_ACTIVE);
+#ifdef QUIC_SILO
+    QuicConfigurationDetachSilo();
+    QuicSiloRelease(Silo);
+#endif
 }
 
 _IRQL_requires_max_(PASSIVE_LEVEL)