Skip to content

Potential Memory Leak Due to Missing CXPLAT_FREE() in Error Paths #5255

New issue
New issue
Open
Bug
#5324
Open
Potential Memory Leak Due to Missing CXPLAT_FREE() in Error Paths#5255
Bug
#5324
Assignees
guhetiercopilot-swe-agent
Labels
Area: TestingRelated to test coverageTriagedThis item has been triaged by an MsQuic ownerhelp wantedExtra attention is needed
Milestone
Future
@t-minzheng

Description

@t-minzheng
t-minzheng
opened on Jul 15, 2025

Description
if either of the following calls failed:

msquic/src/tools/ip/server/quicipserver.cpp

Lines 82 to 84 in 07a7c46

if (QUIC_FAILED(Status = MsQuic->StreamOpen(Connection, QUIC_STREAM_OPEN_FLAG_UNIDIRECTIONAL, ServerStreamCallback, nullptr, &Stream))) {
printf("StreamOpen failed, 0x%x!\n", Status);
return;

msquic/src/tools/ip/server/quicipserver.cpp

Lines 87 to 91 in 07a7c46

if (QUIC_FAILED(Status = MsQuic->StreamStart(Stream, QUIC_STREAM_START_FLAG_NONE))) {
printf("StreamStart failed, 0x%x!\n", Status);
MsQuic->StreamClose(Stream);
return;
}

The allocated SendBuffer would not be freed, leading to a memory leak.

Suggested fix
Add CXPLAT_FREE(SendBuffer, QUIC_POOL_TOOL); in those paths. Ensure that for every CXPLAT_ALLOC there is a corresponding CXPLAT_FREE in all exit paths.

Metadata

Metadata

Assignees

Labels

Area: TestingRelated to test coverageTriagedThis item has been triaged by an MsQuic ownerhelp wantedExtra attention is needed

Type

Bug

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions