Miss check for the return value of CXPLAT_ALLOC_NONPAGED and CxPlatPoolAlloc

**Description**
There are several instances in the codebase where the return value of` CXPLAT_ALLOC_NONPAGED` and `CxPlatPoolAlloc` is not checked before being used.


https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/perf/lib/Tcp.cpp#L706-L707

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/core/unittest/RecvBufferTest.cpp#L55-L58

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/core/unittest/RecvBufferTest.cpp#L77-L79

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/core/unittest/RecvBufferTest.cpp#L78-L79

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/core/unittest/RecvBufferTest.cpp#L82-L84

https://github.com/microsoft/msquic/blob/a6fe43d7928dc550b2f24599a2769df0358f963d/src/platform/unittest/TlsTest.cpp#L588-L596

**Suggested Fix**
Add a null check immediately after each `CXPLAT_ALLOC_NONPAGED` and `CxPlatPoolAlloc` call, and handle the failure case appropriately 

	PreallocChunk = (QUIC_RECV_CHUNK*)CXPLAT_ALLOC_NONPAGED(
	sizeof(QUIC_RECV_CHUNK) + AllocBufferLength,
	QUIC_POOL_RECVBUF); // Use the recv buffer pool tag as this memory is moved to the recv buffer.
	QuicRecvChunkInitialize(PreallocChunk, AllocBufferLength, (uint8_t*)(PreallocChunk + 1), FALSE);

	Context->ReceivedSessionTicket.Buffer = // N.B - Add one so we don't ever allocate zero bytes.
	(uint8_t*)CXPLAT_ALLOC_NONPAGED(TicketLength+1, QUIC_POOL_CRYPTO_RESUMPTION_TICKET);
	Context->ReceivedSessionTicket.Length = TicketLength;
	if (TicketLength != 0) {
	CxPlatCopyMemory(
	Context->ReceivedSessionTicket.Buffer,
	Ticket,
	TicketLength);
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Miss check for the return value of CXPLAT_ALLOC_NONPAGED and CxPlatPoolAlloc #5233

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	uint8_t* LocalTP = (uint8_t*)CXPLAT_ALLOC_NONPAGED(CxPlatTlsTPHeaderSize + LocalTPLength, QUIC_POOL_TLS_TRANSPARAMS);
	CxPlatZeroMemory(LocalTP, LocalTPLength);

	AppOwnedBuffer = (uint8_t *)CXPLAT_ALLOC_NONPAGED(VirtualBufferLength, QUIC_POOL_TEST);
	auto* Chunk = (QUIC_RECV_CHUNK *)CxPlatPoolAlloc(&AppBufferChunkPool);
	QuicRecvChunkInitialize(Chunk, AllocBufferLength, AppOwnedBuffer, TRUE);

	auto* Chunk2 = (QUIC_RECV_CHUNK *)CxPlatPoolAlloc(&AppBufferChunkPool);
	QuicRecvChunkInitialize(Chunk2, VirtualBufferLength - AllocBufferLength, AppOwnedBuffer + AllocBufferLength, TRUE);
	CxPlatListInsertTail(&ChunkList, &Chunk2->Link);

Miss check for the return value of CXPLAT_ALLOC_NONPAGED and CxPlatPoolAlloc #5233

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions