Merge pull request #235 from microsoft/limit-offset-sql-fix

mShan0 · web-flow · commit 05fcbd429199 · 2023-03-13T14:32:54.000-07:00
Fix limit_offset_sql to handle cases when there is no OFFSET
diff --git a/mssql/operations.py b/mssql/operations.py
@@ -404,7 +404,7 @@ def limit_offset_sql(self, low_mark, high_mark):
         """Return LIMIT/OFFSET SQL clause."""
         limit, offset = self._get_limit_offset_params(low_mark, high_mark)
         return '%s%s' % (
-            (' OFFSET %d ROWS' % offset) if offset else '',
+            (' OFFSET %d ROWS' % offset) if offset else ' OFFSET 0 ROWS',
             (' FETCH FIRST %d ROWS ONLY' % limit) if limit else '',
         )
 

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ def limit_offset_sql(self, low_mark, high_mark):`
`404`	`404`	`"""Return LIMIT/OFFSET SQL clause."""`
`405`	`405`	`limit, offset = self._get_limit_offset_params(low_mark, high_mark)`
`406`	`406`	`return '%s%s' % (`
`407`		`- (' OFFSET %d ROWS' % offset) if offset else '',`
	`407`	`+ (' OFFSET %d ROWS' % offset) if offset else ' OFFSET 0 ROWS',`
`408`	`408`	`(' FETCH FIRST %d ROWS ONLY' % limit) if limit else '',`
`409`	`409`	`)`
`410`	`410`