Add max_length parameter to binaryfield

Author: absci

mssql/base.py

@@ -75,7 +75,7 @@ class DatabaseWrapper(BaseDatabaseWrapper):
         'AutoField': 'int',
         'BigAutoField': 'bigint',
         'BigIntegerField': 'bigint',
-        'BinaryField': 'varbinary(max)',
+        'BinaryField': 'varbinary(%(max_length)s)',
         'BooleanField': 'bit',
         'CharField': 'nvarchar(%(max_length)s)',
         'DateField': 'date',

mssql/functions.py

@@ -11,6 +11,8 @@
 from django.db.models.expressions import Case, Exists, OrderBy, When, Window
 from django.db.models.lookups import Lookup, In
 from django.db.models import lookups
+from django.db.models.fields import BinaryField, Field
+from django.core import validators
 
 if VERSION >= (3, 1):
     from django.db.models.fields.json import (
@@ -187,6 +189,14 @@ def json_HasKeyLookup(self, compiler, connection):
 
     return sql % tuple(rhs_params), []
 
+def BinaryField_init(self, *args, **kwargs):
+    # Add max_length option for BinaryField, default to max
+    kwargs.setdefault('editable', False)
+    Field.__init__(self, *args, **kwargs)
+    if self.max_length is not None:
+        self.validators.append(validators.MaxLengthValidator(self.max_length))
+    else:
+        self.max_length = 'max'
 
 ATan2.as_microsoft = sqlserver_atan2
 In.split_parameter_list_as_sql = split_parameter_list_as_sql
@@ -200,6 +210,7 @@ def json_HasKeyLookup(self, compiler, connection):
 NthValue.as_microsoft = sqlserver_nth_value
 Round.as_microsoft = sqlserver_round
 Window.as_microsoft = sqlserver_window
+BinaryField.__init__ = BinaryField_init
 
 if VERSION >= (3, 2):
     Random.as_microsoft = sqlserver_random

testapp/settings.py

@@ -57,6 +57,7 @@
                   'expressions_window.tests.WindowFunctionTests.test_nth_returns_null',
                   'expressions_window.tests.WindowFunctionTests.test_nthvalue',
                   'expressions_window.tests.WindowFunctionTests.test_range_n_preceding_and_following',
+                  'field_deconstruction.tests.FieldDeconstructionTests.test_binary_field',
                   'ordering.tests.OrderingTests.test_orders_nulls_first_on_filtered_subquery',
                   'queries.test_bulk_update.BulkUpdateNoteTests.test_set_field_to_null',
                   'get_or_create.tests.UpdateOrCreateTransactionTests.test_creation_in_transaction',