Update get_table_list and add version condition to db_comment

Author: dauinsight

mssql/introspection.py

@@ -82,12 +82,10 @@ def get_table_list(self, cursor):
                     TABLE_TYPE,
                     CAST(ep.value AS VARCHAR) AS COMMENT
                 FROM INFORMATION_SCHEMA.TABLES i
-                INNER JOIN sys.tables t ON t.name = i.TABLE_NAME
+                LEFT JOIN sys.tables t ON t.name = i.TABLE_NAME
                 LEFT JOIN sys.extended_properties ep ON t.object_id = ep.major_id
-                WHERE
-                    ((ep.name = 'MS_DESCRIPTION' AND ep.minor_id >= 0) OR ep.value IS NULL)
-                    AND
-                    i.TABLE_SCHEMA = %s""" % (
+                AND ((ep.name = 'MS_DESCRIPTION' AND ep.minor_id = 0) OR ep.value IS NULL)
+                AND i.TABLE_SCHEMA = %s""" % (
             get_schema_name())
         cursor.execute(sql)
         types = {'BASE TABLE': 't', 'VIEW': 'v'}

mssql/schema.py

@@ -197,8 +197,6 @@ def _alter_column_null_sql(self, model, old_field, new_field):
     if django_version >= (4, 2):
         def _alter_column_type_sql(self, model, old_field, new_field, new_type, old_collation, new_collation):
             new_type = self._set_field_new_type_null_status(old_field, new_type)
-            # Check if existing
-            # Drop exisiting
             return super()._alter_column_type_sql(model, old_field, new_field, new_type, old_collation, new_collation)
     else:
         def _alter_column_type_sql(self, model, old_field, new_field, new_type):
@@ -965,17 +963,18 @@ def add_field(self, model, field):
             }
             self.execute(sql, params)
         # Add field comment, if required.
-        if (
-            field.db_comment
-            and self.connection.features.supports_comments
-            and not self.connection.features.supports_comments_inline
-        ):
-            field_type = db_params["type"]
-            self.execute(
-                *self._alter_column_comment_sql(
-                    model, field, field_type, field.db_comment
+        if django_version >= (4, 2):
+            if (
+                field.db_comment
+                and self.connection.features.supports_comments
+                and not self.connection.features.supports_comments_inline
+            ):
+                field_type = db_params["type"]
+                self.execute(
+                    *self._alter_column_comment_sql(
+                        model, field, field_type, field.db_comment
+                    )
                 )
-            )
         # Add an index, if required
         self.deferred_sql.extend(self._field_indexes_sql(model, field))
         # Add any FK constraints later