Added test to verify fallback to normal execution for bulk copy api

Author: muskan124947

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkBatchInsertRecord.java

@@ -7,7 +7,6 @@
 
 import java.math.BigDecimal;
 import java.math.RoundingMode;
-import java.nio.charset.Charset;
 import java.sql.Types;
 import java.text.DecimalFormat;
 import java.text.MessageFormat;
@@ -35,7 +34,6 @@ class SQLServerBulkBatchInsertRecord extends SQLServerBulkRecord {
     private int batchParamIndex = -1;
     private List<String> columnList;
     private List<String> valueList;
-    private Charset charset;
 
     /*
      * Class name for logging.
@@ -46,10 +44,10 @@ class SQLServerBulkBatchInsertRecord extends SQLServerBulkRecord {
      * Constructs a SQLServerBulkBatchInsertRecord with the batch parameter, column list, value list, and encoding
      */
     SQLServerBulkBatchInsertRecord(ArrayList<Parameter[]> batchParam, ArrayList<String> columnList,
-            ArrayList<String> valueList, Charset charset, boolean columnNameCaseSensitive) throws SQLServerException {
+            ArrayList<String> valueList, String encoding, boolean columnNameCaseSensitive) throws SQLServerException {
         initLoggerResources();
         if (loggerExternal.isLoggable(java.util.logging.Level.FINER)) {
-            loggerExternal.entering(loggerPackageName, loggerClassName, new Object[] {batchParam, charset.name()});
+            loggerExternal.entering(loggerPackageName, loggerClassName, new Object[] {batchParam, encoding});
         }
 
         if (null == batchParam) {
@@ -64,7 +62,6 @@ class SQLServerBulkBatchInsertRecord extends SQLServerBulkRecord {
         this.columnList = columnList;
         this.valueList = valueList;
         this.columnNameCaseSensitive = columnNameCaseSensitive;
-        this.charset = charset;
         columnMetadata = new HashMap<>();
 
         loggerExternal.exiting(loggerPackageName, loggerClassName);

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java

@@ -2218,8 +2218,7 @@ public int[] executeBatch() throws SQLServerException, BatchUpdateException, SQL
                         }
 
                         SQLServerBulkBatchInsertRecord batchRecord = new SQLServerBulkBatchInsertRecord(
-                                batchParamValues, bcOperationColumnList, bcOperationValueList, 
-                                connection.getDatabaseCollation().getCharset(), isDBColationCaseSensitive());
+                                batchParamValues, bcOperationColumnList, bcOperationValueList, null, isDBColationCaseSensitive());
 
                         for (int i = 1; i <= rs.getColumnCount(); i++) {
                             Column c = rs.getColumn(i);
@@ -2427,8 +2426,7 @@ public long[] executeLargeBatch() throws SQLServerException, BatchUpdateExceptio
                         }
 
                         SQLServerBulkBatchInsertRecord batchRecord = new SQLServerBulkBatchInsertRecord(
-                                batchParamValues, bcOperationColumnList, bcOperationValueList, 
-                                connection.getDatabaseCollation().getCharset(), isDBColationCaseSensitive());
+                                batchParamValues, bcOperationColumnList, bcOperationValueList, null, isDBColationCaseSensitive());
 
                         for (int i = 1; i <= rs.getColumnCount(); i++) {
                             Column c = rs.getColumn(i);

src/test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java

@@ -32,6 +32,7 @@
 import java.util.UUID;
 
 import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Tag;
@@ -1407,6 +1408,54 @@ private void getCreateTableTemporalSQL(String tableName) throws SQLException {
         }
     }
 
+    /**
+     * Test insert-select fallback to normal execution for bulk copy API
+     */
+    @Test
+    public void testInsertSelectFallbackToNormalExecution() throws Exception {
+        String tableNameSource = AbstractSQLGenerator.escapeIdentifier("SourceTable");
+        String tableNameDestination = AbstractSQLGenerator.escapeIdentifier("DestinationTable");
+
+        String connectStringUrl = connectionString
+                + ";useBulkCopyForBatchInsert=true;sendStringParametersAsUnicode=false;";
+
+        try (Connection connection = PrepUtil.getConnection(connectStringUrl);
+                Statement stmt = connection.createStatement()) {
+
+            TestUtils.dropTableIfExists(tableNameSource, stmt);
+            String createSourceTableSQL = "CREATE TABLE " + tableNameSource + " (id INT, value VARCHAR(50))";
+            stmt.execute(createSourceTableSQL);
+
+            String insertSourceDataSQL = "INSERT INTO " + tableNameSource + " VALUES (1, 'TestValue1'), (2, 'TestValue2')";
+            stmt.execute(insertSourceDataSQL);
+
+            TestUtils.dropTableIfExists(tableNameDestination, stmt);
+            String createDestinationTableSQL = "CREATE TABLE " + tableNameDestination + " (id INT, value VARCHAR(50))";
+            stmt.execute(createDestinationTableSQL);
+
+            // Attempt unsupported INSERT-SELECT query for bulk copy api
+            String insertSelectSQL = "INSERT INTO " + tableNameDestination + " SELECT * FROM " + tableNameSource
+                    + " WHERE id = ?";
+
+            try (SQLServerPreparedStatement pstmt = (SQLServerPreparedStatement) connection
+                    .prepareStatement(insertSelectSQL)) {
+                pstmt.setInt(1, 1);
+                pstmt.addBatch();
+                pstmt.executeBatch(); // This should fall back to normal execution flow
+            }
+
+            // Validate inserted data in destination table
+            String selectSQL = "SELECT * FROM " + tableNameDestination;
+            try (ResultSet rs = stmt.executeQuery(selectSQL)) {
+                assertTrue(rs.next(), "Expected at least one row in result set");
+                assertEquals(1, rs.getInt("id"));
+                assertEquals("TestValue1", rs.getString("value"));
+
+                Assertions.assertFalse(rs.next(), "No more rows expected");
+            }
+        }
+    }
+
     /**
      * Test string values using prepared statement using accented and unicode characters.
      * This test covers all combinations of useBulkCopyForBatchInsert and sendStringParametersAsUnicode.